Skip to content

bug: datetime, empty picker items are read by some screen readers #26809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shivamsharmanps opened this issue Feb 15, 2023 · 9 comments · Fixed by #27038
Closed

bug: datetime, empty picker items are read by some screen readers #26809

shivamsharmanps opened this issue Feb 15, 2023 · 9 comments · Fixed by #27038
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@shivamsharmanps
Copy link

shivamsharmanps commented Feb 15, 2023

Describe the Bug

Hi,

is not support accessibility, when we can expect to get support, it reads whitespace when use 'md' mode and behave differently and for physically challenge person this will hard, could you bring full accessibility support.

Expected Behavior

accessibility support for datetime-picker.

Steps to Reproduce

When clicking on month or year and moving up/down to select then it reads black/space.

Screenshots

image

Operating System

Windows 10

Browser

Chrome/Edge

Version

Version 110

Additional Information

Please add accessibility for <ion-datetime></ion-datetime>.

@shivamsharmanps shivamsharmanps changed the title bug: bug: <ion-datetime></ion-datetime> Accessibility is not supporting Feb 15, 2023
@averyjohnston
Copy link
Contributor

Thank you for the issue. Could you give more details on the problem you're experiencing? I'm not sure I understand everything. A screen recording may help.

@averyjohnston averyjohnston added the needs: reply the issue needs a response from the user label Feb 15, 2023
@ionitron-bot ionitron-bot bot removed the triage label Feb 15, 2023
@shivamsharmanps
Copy link
Author

I am not able to record the video but I am attaching a screenshot which I think will help to understand -
image

The red square is read as 'Blank' or 'Space' by JAWS tool ( screen reader ), I am using ionic example https://ionicframework.com/docs/api/datetime#basic-usage.
In ionic, most of the things related to accessibility are not working, and for a better experience tried angular material where tools.
working far better, but hoping to get better accessibility result from ionic.

@ionitron-bot ionitron-bot bot added triage and removed needs: reply the issue needs a response from the user labels Feb 15, 2023
@shivamsharmanps
Copy link
Author

I found a issue
image
this where reader read blank.

@averyjohnston averyjohnston transferred this issue from ionic-team/ionic-docs Feb 16, 2023
@averyjohnston averyjohnston self-assigned this Feb 16, 2023
@averyjohnston
Copy link
Contributor

Thank you for the details. While I don't have JAWS to test with, we should be able to fix things by adding aria-hidden="true" to those elements.

If you are having other accessibility problems as well, I would recommend opening separate issues in the ionic-framework repo: https://github.com/ionic-team/ionic-framework/issues/new/choose

@averyjohnston averyjohnston changed the title bug: <ion-datetime></ion-datetime> Accessibility is not supporting bug: datetime, empty picker items are read by some screen readers Feb 16, 2023
@averyjohnston averyjohnston added package: core @ionic/core package type: bug a confirmed bug report labels Feb 16, 2023
@averyjohnston averyjohnston removed their assignment Feb 16, 2023
@shivamsharmanps
Copy link
Author

I am looking something like this for web/mobile.
https://www.youtube.com/watch?v=yotebj3ibEE

@shivamsharmanps
Copy link
Author

Thank you for the details. While I don't have JAWS to test with, we should be able to fix things by adding aria-hidden="true" to those elements.

If you are having other accessibility problems as well, I would recommend opening separate issues in the ionic-framework repo: https://github.com/ionic-team/ionic-framework/issues/new/choose

Actually those element we see when run app ( web )
i.e. https://user-images.githubusercontent.com/50568306/219291602-6814f36c-d009-4b66-b220-65f271637c6a.png
so how can I add there and that are inside shadow-root( open)

@averyjohnston
Copy link
Contributor

I am looking something like this for web/mobile. https://www.youtube.com/watch?v=yotebj3ibEE

Please file a separate issue on the ionic-framework repo and include a minimal reproduction app so we can troubleshoot further.

Actually those element we see when run app ( web ) i.e. https://user-images.githubusercontent.com/50568306/219291602-6814f36c-d009-4b66-b220-65f271637c6a.png so how can I add there and that are inside shadow-root( open)

We'll need to fix it on our end.

@brandyscarney
Copy link
Member

Hello @shivamsharmanps! I have released a dev build with a potential fix for your issue. Could you please test this and let us know if it resolves this? Thank you!

If you are using angular:

npm i @ionic/angular@6.6.2-dev.11680021138.106a5859

brandyscarney added a commit that referenced this issue Apr 4, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…rs (#27038)

* fix(picker-column): hide empty picker items from screenreaders

fixes #26809

* style(picker-column-internal): run lint

---------

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
brandyscarney added a commit that referenced this issue Apr 4, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…rs (#27114)

fixes #26809
@ionitron-bot
Copy link

ionitron-bot bot commented May 4, 2023

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants