Skip to content

bug: ionic uses styles that supported only in chrome 88, while ionic 6 should support 60+ #26745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 of 8 tasks
Serg-Mois opened this issue Feb 7, 2023 · 4 comments
Closed
4 of 8 tasks
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@Serg-Mois
Copy link

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x
  • v7.x
  • Nightly

Current Behavior

In https://github.com/ionic-team/ionic-framework/blob/main/core/src/css/core.scss you have added:

ion-modal .ion-page:not(ion-nav .ion-page) {
  position: relative;
  contain: layout style;
  height: 100%;
}

it's a selector that is added only in 88 chrome: https://caniuse.com/css-not-sel-lis, while ionic 6 must support chrome 60+ - https://ionicframework.com/docs/reference/browser-support. Now view looks different for old and new devices.

Expected Behavior

Use other selector , supported in chrome 60.

Steps to Reproduce

No need to reproduce. A file with the code is provided.

Code Reproduction URL

No response

Ionic Info

ionic 6.5.0

Additional Information

No response

@ionitron-bot ionitron-bot bot added the triage label Feb 7, 2023
@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report labels Feb 7, 2023
@ionitron-bot ionitron-bot bot removed the triage label Feb 7, 2023
@liamdebeasi
Copy link
Contributor

Thanks for the report. Here is a dev build with a proposed fix if you are interested in testing:

Angular

npm install @ionic/angular@6.5.3-dev.11675782754.10ad7d4a

React

npm install @ionic/react@6.5.3-dev.11675782754.10ad7d4a @ionic/react-router@6.5.3-dev.11675782754.10ad7d4a

Vue

npm install @ionic/vue@6.5.3-dev.11675782754.10ad7d4a @ionic/vue-router@6.5.3-dev.11675782754.10ad7d4a

Stencil/Vanilla JavaScript

npm install @ionic/core@6.5.3-dev.11675782754.10ad7d4a

liamdebeasi added a commit that referenced this issue Feb 7, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
resolves #26745
@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #26746, and a fix will be available in an upcoming minor release of Ionic Framework. Please feel free to continue testing the dev build, and let me know if you have any questions.

@mgltuba
Copy link

mgltuba commented Mar 3, 2023

how set ion-datetime short month names with custom locale
image

@ionitron-bot
Copy link

ionitron-bot bot commented Apr 2, 2023

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Apr 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

3 participants