fix(react): hardware back button works in dev mode #26614
Merged
+4
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #26599
The current
NavManager
implementation adds anionBackButton
listener in the constructor. This allows it to respond to hardware back button presses on Android. When the component is unmounted, the event listener is removed. The event listener only proceeds ifthis._isMounted
istrue
(i.e. if the component is mounted). If the component is not mounted, the handler returns and no other hardware back button handlers are processed.In dev mode in React, the
NavManager
will be created multiple times, but not every instance will be mounted. As a result, there can be instances ofNavManager
that receive hardware back button events but effectively block any processing since these instances are not mounted. This results in hardware back button behavior being broken when testing an app in development mode.This behavior does not impact production mode.
What is the new behavior?
ionBackButton
listener forNavManager
is added in thecomponentDidMount
component lifecycle instead of in the constructorthis._isMounted
flagDoes this introduce a breaking change?
Other information