Skip to content

fix(datetime): keyboard can select hour 00 #26423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 7, 2022
Merged

fix(datetime): keyboard can select hour 00 #26423

merged 7 commits into from
Dec 7, 2022

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Dec 6, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #26409

The regular expression for text entry stripped a string of all leading zeros. As a result, the 24 hour time entry for midnight ('00') became the empty string ('') which never matched the input value.

What is the new behavior?

  • Updated the regular expression to allows at least one 0 to pass through unfiltered if the entire string contains zeros.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@github-actions github-actions bot added the package: core @ionic/core package label Dec 6, 2022
@liamdebeasi liamdebeasi changed the title Fw 2981 fix(datetime): keyboard can select hour 00 Dec 6, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review December 6, 2022 15:23
@liamdebeasi liamdebeasi requested a review from a team as a code owner December 6, 2022 15:23
@liamdebeasi liamdebeasi merged commit 2fc96b7 into main Dec 7, 2022
@liamdebeasi liamdebeasi deleted the FW-2981 branch December 7, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: datetime, cannot entry 00 for time entry
3 participants