Skip to content

fix(datetime): add flipRTL to monthAndYear dropdown icon #26378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 30, 2022
Merged

Conversation

averyjohnston
Copy link
Contributor

@averyjohnston averyjohnston commented Nov 29, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The chevron icon for the month/year dropdown doesn't flip on RTL. For md mode, this doesn't matter because the icon is horizontally symmetrical, but for ios it triggers a visual bug.

Issue URL: N/A

What is the new behavior?

flipRTL prop added to the icon.

Does this introduce a breaking change?

  • Yes
  • No

Other information

This PR is a copy of the change made in #26163, only directly off of main so the screenshot update job can be run. Co-author credit will be given when merging.

Sorry, something went wrong.

Co-authored-by: cdes <cdes@users.noreply.github.com>
@github-actions github-actions bot added the package: core @ionic/core package label Nov 29, 2022
@averyjohnston averyjohnston marked this pull request as ready for review November 30, 2022 15:25
@averyjohnston averyjohnston requested a review from a team as a code owner November 30, 2022 15:25
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
@averyjohnston averyjohnston merged commit 13fe669 into main Nov 30, 2022
@averyjohnston averyjohnston deleted the FW-2675 branch November 30, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants