fix(segment): scrolling button into view is more consistent #26369
+9
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #26368
By default
scrollIntoView
defaults the vertical alignment to the start of the container. While this is the correct browser behavior, we only care about scrolling on the horizontal axis for the segment. As a result, this can cause unnecessary scrolling for complex layouts.What is the new behavior?
'nearest'
strategy. If the segment is fully in view, no vertical scrolling happens. Otherwise the segment is aligned to either the top or the bottom on the content depending on which edge it is closest to.Does this introduce a breaking change?
Other information