Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(segment): scrolling button into view is more consistent #26369

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 29, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #26368

By default scrollIntoView defaults the vertical alignment to the start of the container. While this is the correct browser behavior, we only care about scrolling on the horizontal axis for the segment. As a result, this can cause unnecessary scrolling for complex layouts.

What is the new behavior?

  • The segment is now vertically aligned using the 'nearest' strategy. If the segment is fully in view, no vertical scrolling happens. Otherwise the segment is aligned to either the top or the bottom on the content depending on which edge it is closest to.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@github-actions github-actions bot added the package: core @ionic/core package label Nov 29, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review November 29, 2022 17:44
@liamdebeasi liamdebeasi requested a review from a team as a code owner November 29, 2022 17:44
@liamdebeasi liamdebeasi merged commit a2d570b into main Nov 30, 2022
@liamdebeasi liamdebeasi deleted the FW-2920 branch November 30, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: segment should avoid vertical scrolling if already in view
3 participants