Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: breadcrumbs are not reactive #24041

Closed
4 of 6 tasks
tetkosimi opened this issue Oct 7, 2021 · 5 comments
Closed
4 of 6 tasks

bug: breadcrumbs are not reactive #24041

tetkosimi opened this issue Oct 7, 2021 · 5 comments
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@tetkosimi
Copy link
Contributor

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x

Current Behavior

ion-breadcrumbs properties are not updating when new ion-breadcrumb have been added or removed.

Expected Behavior

Watch for children changes to maintain expected active breadcrumb number and last property.

Steps to Reproduce

  1. Add new ion-breadcrumb to ion-breadcrumbs.

Code Reproduction URL

No response

Ionic Info

No response

Additional Information

No response

@liamdebeasi
Copy link
Contributor

Thanks for the issue. Could you please reproduce this issue in an Ionic app and provide a link to the repo?

@liamdebeasi liamdebeasi added the needs: reply the issue needs a response from the user label Oct 7, 2021
@ionitron-bot ionitron-bot bot removed the triage label Oct 7, 2021
@tetkosimi
Copy link
Contributor Author

tetkosimi commented Oct 7, 2021

@ionitron-bot ionitron-bot bot added triage and removed needs: reply the issue needs a response from the user labels Oct 7, 2021
@liamdebeasi
Copy link
Contributor

Thanks! Looks like ion-breadcrumbs is not reactive at the moment. I think we may go in a different direction for this fix as this should work without a MutationObserver, but I need to do some exploration on this.

@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report v6 issues specific to Framework v6 labels Oct 7, 2021
@ionitron-bot ionitron-bot bot removed the triage label Oct 7, 2021
@liamdebeasi liamdebeasi changed the title bug: Missing update for breadcrumbs bug: breadcrumbs are not reactive Oct 7, 2021
@sean-perkins
Copy link
Contributor

Looks like we could possibly use onSlotChange on the slot in ion-breadcrumbs to reset active breadcrumb/re-init breadcrumbs. I'm a little uncertain in the caniuse chart; as Chrome states not supported, but definitely is.

@liamdebeasi liamdebeasi added type: bug a confirmed bug report and removed type: bug a confirmed bug report v6 issues specific to Framework v6 labels Nov 30, 2022
@ionitron-bot
Copy link

ionitron-bot bot commented Jan 8, 2023

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

3 participants