Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ionic-team/ionic-framework
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.6.7
Choose a base ref
...
head repository: ionic-team/ionic-framework
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.6.8
Choose a head ref
  • 16 commits
  • 86 files changed
  • 5 contributors

Commits on May 13, 2021

  1. merge release-5.6.7

    5.6.7
    liamdebeasi authored May 13, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    eb10a2a View commit details

Commits on May 14, 2021

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    4da5216 View commit details

Commits on May 17, 2021

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    faa93ad View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    6bfe1ce View commit details

Commits on May 20, 2021

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    56f6f56 View commit details

Commits on May 21, 2021

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    d473a53 View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    a708c41 View commit details
  3. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    881dcff View commit details
  4. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    08a9f3a View commit details
  5. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    dc430af View commit details

Commits on May 24, 2021

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    1a36922 View commit details
  2. fix(react): remove @ionic/core dependency in @ionic/react-router to r…

    …esolve yarn install warning (#23351)
    
    resolves #23346
    liamdebeasi authored May 24, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    36bfa33 View commit details
  3. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    bc2f1b8 View commit details

Commits on May 25, 2021

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    2933531 View commit details

Commits on May 26, 2021

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    3d474ec View commit details

Commits on May 27, 2021

  1. 5.6.8

    liamdebeasi committed May 27, 2021
    Copy the full SHA
    565361b View commit details
Showing with 731 additions and 345 deletions.
  1. +7 −19 .circleci/config.yml
  2. +37 −0 .github/COMPONENT-GUIDE.md
  3. +1 −1 .github/PROCESS.md
  4. +18 −0 CHANGELOG.md
  5. +9 −9 angular/package-lock.json
  6. +2 −2 angular/package.json
  7. +33 −33 core/api.txt
  8. +158 −27 core/package-lock.json
  9. +3 −3 core/package.json
  10. +1 −3 core/scripts/screenshot/ci.js
  11. +0 −12 core/scripts/swiper.rollup.config.js
  12. +2 −2 core/src/components.d.ts
  13. +1 −1 core/src/components/action-sheet/action-sheet.md.scss
  14. +1 −0 core/src/components/action-sheet/test/basic/index.html
  15. +1 −1 core/src/components/back-button/back-button.tsx
  16. +1 −1 core/src/components/badge/badge.tsx
  17. +1 −1 core/src/components/button/button.tsx
  18. +1 −1 core/src/components/card-header/card-header.tsx
  19. +1 −1 core/src/components/card-subtitle/card-subtitle.tsx
  20. +1 −1 core/src/components/card-title/card-title.tsx
  21. +1 −1 core/src/components/card/card.tsx
  22. +1 −1 core/src/components/checkbox/checkbox.tsx
  23. +1 −1 core/src/components/chip/chip.tsx
  24. +1 −1 core/src/components/content/content.tsx
  25. +1 −1 core/src/components/fab-button/fab-button.tsx
  26. +16 −14 core/src/components/fab/readme.md
  27. +16 −14 core/src/components/fab/usage/vue.md
  28. +1 −1 core/src/components/input/input.tsx
  29. +1 −1 core/src/components/item-divider/item-divider.tsx
  30. +1 −1 core/src/components/item-option/item-option.tsx
  31. +1 −1 core/src/components/item/item.tsx
  32. +1 −1 core/src/components/label/label.tsx
  33. +1 −1 core/src/components/list-header/list-header.tsx
  34. +1 −1 core/src/components/menu-button/menu-button.tsx
  35. +1 −1 core/src/components/note/note.tsx
  36. +1 −1 core/src/components/progress-bar/progress-bar.tsx
  37. +1 −1 core/src/components/radio/radio.tsx
  38. +36 −6 core/src/components/range/range.tsx
  39. +32 −0 core/src/components/range/test/a11y/index.html
  40. +14 −0 core/src/components/range/test/a11y/screen-readers.md
  41. +20 −20 core/src/components/range/test/basic/index.html
  42. +7 −7 core/src/components/range/test/standalone/index.html
  43. +1 −1 core/src/components/router-link/router-link.tsx
  44. +4 −4 core/src/components/router/readme.md
  45. +43 −37 core/src/components/router/router.tsx
  46. +2 −1 core/src/components/router/test/basic/index.html
  47. +12 −0 core/src/components/router/test/basic/redirect.e2e.ts
  48. +1 −1 core/src/components/router/test/e2e.spec.tsx
  49. +16 −0 core/src/components/router/test/guards/basic.e2e.ts
  50. +24 −0 core/src/components/router/test/guards/index.html
  51. +0 −1 core/src/components/router/test/guards/router-link.e2e.ts
  52. +0 −1 core/src/components/router/test/guards/router-push.e2e.ts
  53. +1 −1 core/src/components/router/test/matching.spec.tsx
  54. +6 −4 core/src/components/router/test/parser.spec.tsx
  55. +20 −13 core/src/components/router/test/path.spec.tsx
  56. +1 −1 core/src/components/router/utils/debug.ts
  57. +8 −1 core/src/components/router/utils/interface.ts
  58. +13 −7 core/src/components/router/utils/matching.ts
  59. +2 −2 core/src/components/router/utils/parser.ts
  60. +26 −17 core/src/components/router/utils/path.ts
  61. +1 −1 core/src/components/searchbar/searchbar.tsx
  62. +1 −1 core/src/components/segment/segment.tsx
  63. +8 −3 core/src/components/skeleton-text/skeleton-text.scss
  64. +2 −2 core/src/components/slides/swiper/swiper.bundle.js
  65. +1 −1 core/src/components/spinner/spinner.tsx
  66. +1 −1 core/src/components/tab-bar/tab-bar.tsx
  67. +1 −1 core/src/components/text/text.tsx
  68. +1 −1 core/src/components/textarea/textarea.tsx
  69. +5 −1 core/src/components/title/title.ios.scss
  70. +2 −1 core/src/components/title/title.tsx
  71. +1 −1 core/src/components/toast/toast.tsx
  72. +1 −1 core/src/components/toggle/toggle.tsx
  73. +1 −1 core/src/components/toolbar/toolbar.tsx
  74. +1 −1 docs/package.json
  75. +9 −9 packages/angular-server/package-lock.json
  76. +2 −2 packages/angular-server/package.json
  77. +4 −5 packages/react-router/package.json
  78. +11 −1 packages/react-router/src/ReactRouter/IonReactHashRouter.tsx
  79. +11 −1 packages/react-router/src/ReactRouter/IonReactMemoryRouter.tsx
  80. +14 −4 packages/react-router/src/ReactRouter/IonReactRouter.tsx
  81. +19 −3 packages/react-router/src/ReactRouter/IonRouter.tsx
  82. +2 −2 packages/react/package.json
  83. +5 −3 packages/vue-router/package-lock.json
  84. +1 −1 packages/vue-router/package.json
  85. +9 −9 packages/vue/package-lock.json
  86. +2 −2 packages/vue/package.json
26 changes: 7 additions & 19 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -266,7 +266,7 @@ jobs:
- attach_workspace:
at: /tmp/workspace
- run:
command: npm run test.e2e --ci
command: npm run test.e2e -- --ci --no-build
working_directory: /tmp/workspace/core

test-core-spec:
@@ -276,7 +276,7 @@ jobs:
- attach_workspace:
at: /tmp/workspace
- run:
command: npm run test.spec --ci
command: npm run test.spec -- --ci
working_directory: /tmp/workspace/core

test-core-treeshake:
@@ -286,7 +286,7 @@ jobs:
- attach_workspace:
at: /tmp/workspace
- run:
command: npm run test.treeshake --ci
command: npm run test.treeshake -- --ci
working_directory: /tmp/workspace/core

test-core-screenshot:
@@ -297,7 +297,7 @@ jobs:
at: /tmp/workspace
- run:
name: Run Screenshot
command: npx stencil test --e2e --screenshot --screenshot-connector=scripts/screenshot/ci.js --ci || true
command: npx stencil test --e2e --screenshot --screenshot-connector=scripts/screenshot/ci.js --ci --no-build || true
working_directory: /tmp/workspace/core

test-core-screenshot-master:
@@ -308,7 +308,7 @@ jobs:
at: /tmp/workspace
- run:
name: Run Screenshot
command: npx stencil test --e2e --screenshot --screenshot-connector=scripts/screenshot/ci.js --ci --update-screenshot || true
command: npx stencil test --e2e --screenshot --screenshot-connector=scripts/screenshot/ci.js --ci --update-screenshot --no-build || true
working_directory: /tmp/workspace/core

test-angular-lint:
@@ -475,7 +475,7 @@ jobs:
paths:
- packages/vue/test-app

test-vue-spec:
test-vue-spec-and-e2e:
<<: *defaults
steps:
- checkout
@@ -487,16 +487,6 @@ jobs:
- run:
command: npm run test:unit
working_directory: /tmp/workspace/packages/vue/test-app

test-vue-e2e:
<<: *defaults
steps:
- checkout
- attach_workspace:
at: /tmp/workspace
- run:
command: npm run sync
working_directory: /tmp/workspace/packages/vue/test-app
- run:
command: CYPRESS_CACHE_FOLDER=/tmp/workspace/packages/vue/test-app npm run test:e2e
working_directory: /tmp/workspace/packages/vue/test-app
@@ -565,9 +555,7 @@ workflows:
requires: [build-vue-router]
- install-vue-test-app:
requires: [build-core]
- test-vue-spec:
requires: [install-vue-test-app, build-vue, build-vue-router]
- test-vue-e2e:
- test-vue-spec-and-e2e:
requires: [install-vue-test-app, build-vue, build-vue-router]
- test-angular-lint:
requires: [build-angular]
37 changes: 37 additions & 0 deletions .github/COMPONENT-GUIDE.md
Original file line number Diff line number Diff line change
@@ -16,6 +16,7 @@
* [Example Components](#example-components-1)
* [Component Structure](#component-structure-1)
- [Converting Scoped to Shadow](#converting-scoped-to-shadow)
- [RTL](#rtl)

## Button States

@@ -703,3 +704,39 @@ There will be some CSS issues when converting to shadow. Below are some of the d
/* IN SHADOW*/
:host-context(ion-toolbar:not(.ion-color)):host(:not(.ion-color)) ::slotted(ion-segment-button) {
```
## RTL
When you need to support both LTR and RTL modes, try to avoid using values such as `left` and `right`. For certain CSS properties, you can use the appropriate mixin to have this handled for you automatically.
For example, if you wanted `transform-origin` to be RTL-aware, you would use the `transform-origin` mixin:
```css
@include transform-origin(start, center);
```
This would output `transform-origin: left center` in LTR mode and `transform-origin: right center` in RTL mode.
These mixins depend on the `:host-context` pseudo-class when used inside of shadow components, which is not supported in WebKit. As a result, these mixins will not work in Safari for macOS and iOS when applied to shadow components.
To work around this, you should set an RTL class on the host of your component and set your RTL styles by targeting that class:
```tsx
<Host
class={{
'my-cmp-rtl': document.dir === 'rtl'
})
>
...
</Host>
```
```css
:host {
transform-origin: left center;
}

:host(.my-cmp-rtl) {
transform-origin: right center;
}
```
2 changes: 1 addition & 1 deletion .github/PROCESS.md
Original file line number Diff line number Diff line change
@@ -150,7 +150,7 @@ See the [steps for releasing](#releasing) below for detailed information on how

### Version Branches

Once a release has shipped and the release branch has been merged into `stable` and `master` it should also be merged into its corrsponding version branch. These version branches allow us to ship updates for specific versions of the framework (i.e. Lets us ship a bug fix that only affects 4.2.x).
Once a release has shipped and the release branch has been merged into `stable` and `master` it should also be merged into its corresponding version branch. These version branches allow us to ship updates for specific versions of the framework (i.e. Lets us ship a bug fix that only affects 4.2.x).

Patch releases should be merged into their corresponding version branches. For example, a `release-4.1.1` branch should be merged into the `4.1.x` version branch and a `release-5.0.1` branch should be merged into the `5.0.x` version branch.

18 changes: 18 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,21 @@
## [5.6.8](https://github.com/ionic-team/ionic/compare/v5.6.7...v5.6.8) (2021-05-27)


### Bug Fixes

* **action-sheet:** subheader no longer overlaps action sheet buttons ([#23318](https://github.com/ionic-team/ionic/issues/23318)) ([d473a53](https://github.com/ionic-team/ionic/commit/d473a5385108ef5f39d7c9a2b2924e89fec631de)), closes [#23316](https://github.com/ionic-team/ionic/issues/23316)
* **all:** reflect color property as an attribute for vue ([#23345](https://github.com/ionic-team/ionic/issues/23345)) ([dc430af](https://github.com/ionic-team/ionic/commit/dc430af906c608f948c8d404ad73ae0e0ac36076)), closes [#23323](https://github.com/ionic-team/ionic/issues/23323)
* **range:** knob can now have an accessible name ([#23338](https://github.com/ionic-team/ionic/issues/23338)) ([881dcff](https://github.com/ionic-team/ionic/commit/881dcff40b8bdcb07b27d4ee812ce4ee64b6ea9a)), closes [#23295](https://github.com/ionic-team/ionic/issues/23295)
* **react:** remove @ionic/core dependency in @ionic/react-router to resolve yarn install warning ([#23351](https://github.com/ionic-team/ionic/issues/23351)) ([36bfa33](https://github.com/ionic-team/ionic/commit/36bfa3350354e09be6c62f4e4bee0c553c5981a3)), closes [#23346](https://github.com/ionic-team/ionic/issues/23346)
* **react:** support history@5 in preparation for react router 6 ([#23297](https://github.com/ionic-team/ionic/issues/23297)) ([4da5216](https://github.com/ionic-team/ionic/commit/4da5216b4f65f3d893cc81ebee77261835218f7f)), closes [#23294](https://github.com/ionic-team/ionic/issues/23294)
* **router:** guards are now triggered on initial navigation ([#23123](https://github.com/ionic-team/ionic/issues/23123)) ([56f6f56](https://github.com/ionic-team/ionic/commit/56f6f56c6665f40ea6bf41be463cd416883359f7)), closes [#22936](https://github.com/ionic-team/ionic/issues/22936)
* **router:** redirects now account for query string ([#23337](https://github.com/ionic-team/ionic/issues/23337)) ([08a9f3a](https://github.com/ionic-team/ionic/commit/08a9f3ac94685c5782dd2fa6b56bf3448729a768)), closes [#23136](https://github.com/ionic-team/ionic/issues/23136)
* **skeleton-text:** animation no longer jumps on large skeleton text elements ([#22697](https://github.com/ionic-team/ionic/issues/22697)) ([1a36922](https://github.com/ionic-team/ionic/commit/1a36922f41f2890c778feedbad9c5b74a72a3907)), closes [#22694](https://github.com/ionic-team/ionic/issues/22694)
* **slides:** resolve prototype pollution in swiper v5 ([#23344](https://github.com/ionic-team/ionic/issues/23344)) ([a708c41](https://github.com/ionic-team/ionic/commit/a708c412625cba475ec7863468dcc2146b8feb7a)), closes [#23342](https://github.com/ionic-team/ionic/issues/23342)
* **title:** large title scale animation is now correct in rtl mode ([#23372](https://github.com/ionic-team/ionic/issues/23372)) ([3d474ec](https://github.com/ionic-team/ionic/commit/3d474ec67ff4192fa3d08e370e20fecbee99a6aa)), closes [#23371](https://github.com/ionic-team/ionic/issues/23371)



## [5.6.7](https://github.com/ionic-team/ionic/compare/v5.6.6...v5.6.7) (2021-05-13)


18 changes: 9 additions & 9 deletions angular/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions angular/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ionic/angular",
"version": "5.6.7",
"version": "5.6.8",
"description": "Angular specific wrappers for @ionic/core",
"keywords": [
"ionic",
@@ -42,7 +42,7 @@
"validate": "npm i && npm run lint && npm run test && npm run build"
},
"dependencies": {
"@ionic/core": "5.6.7",
"@ionic/core": "5.6.8",
"tslib": "^1.9.3"
},
"peerDependencies": {
Loading