Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): update gradle to 8.0.2 and gradle plugin to 8.0.0 #6497

Merged
merged 8 commits into from
Apr 17, 2023

Conversation

IT-MikeS
Copy link
Contributor

@IT-MikeS IT-MikeS commented Apr 12, 2023

Dev build for this PR is tagged as:

@capacitor/{core,cli,android,ios}@5.0.0-dev-20230412T155745.0

@capacitor/{core,cli,android,ios}@5.0.0-dev-20230414T153043.0

@capacitor/{core,cli,android,ios}@5.0.0-dev-20230414T155819.0

@markemer
Copy link
Contributor

We'll have to make sure to update the migrate script if and when we go with this.

@IT-MikeS IT-MikeS changed the title update gradle to 8.0.2 and gradle plugin to 8.0.0-rc01 update gradle to 8.0.2 and gradle plugin to 8.0.0 Apr 14, 2023
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also need to update the wrapper files by running ./gradlew wrapper --distribution-type all --gradle-version 8.0.2 --warning-mode all, but in the android-template it can by tricky since it's missing files

@markemer
Copy link
Contributor

We'll also need to either update the migrate script here or in another PR.

@jcesarmobile
Copy link
Member

Yeah, this pr is only for the template, we need another one updating capacitor android and another updating the migrate command, and the plugins too

@IT-MikeS IT-MikeS changed the title update gradle to 8.0.2 and gradle plugin to 8.0.0 feat(android): update gradle to 8.0.2 and gradle plugin to 8.0.0 Apr 14, 2023
@markemer
Copy link
Contributor

Yeah, this pr is only for the template, we need another one updating capacitor android and another updating the migrate command, and the plugins too

Not to be that guy asking for homework, but should we add subtasks or a bunch of tickets for this stuff?

@IT-MikeS IT-MikeS merged commit 01b5b39 into main Apr 17, 2023
6 checks passed
@IT-MikeS IT-MikeS deleted the gradle-8 branch April 17, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants