Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use text script rather than fixed script paths #789

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

AlexV525
Copy link
Contributor

@AlexV525 AlexV525 commented Nov 8, 2024

Description

The melos executable path could be changed due to environment updates. Using a text script and letting the configuration run in the terminal can reduce the pain of checking out these configurations into version control.

Type of Change

  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
AlexV525 Alex Li
Copy link

docs-page bot commented Nov 8, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/melos~789

Documentation is deployed and generated using docs.page.

@AlexV525
Copy link
Contributor Author

@spydon Thanks for the approve. I have little time to improve this with some potential tests. If you think it's fine then I will mark this as ready.

@spydon
Copy link
Collaborator

spydon commented Nov 14, 2024

@spydon Thanks for the approve. I have little time to improve this with some potential tests. If you think it's fine then I will mark this as ready.

I think it's fine, it looks like it makes sense and I assume you've tested it manually.

@AlexV525 AlexV525 marked this pull request as ready for review November 14, 2024 12:15
@AlexV525 AlexV525 requested a review from spydon November 14, 2024 12:45
@spydon spydon merged commit bc2da5f into invertase:main Nov 14, 2024
10 checks passed
@AlexV525
Copy link
Contributor Author

AlexV525 commented Feb 11, 2025

Hi @spydon. I'm still seeing the old style of generated configurations. I saw the commit was published in v6.3.2 and I was using the exact same version. Is there something missing from the publish?

EDIT: I just found out that I need to upgrade the workspace dependency! Sorry for disturbing.

@spydon
Copy link
Collaborator

spydon commented Feb 11, 2025

Hey @AlexV525, everything should be out.
Maybe something went wrong with this PR so that it didn't have any effect then? 🤔

@spydon
Copy link
Collaborator

spydon commented Feb 11, 2025

Have you tried if it works on the 7.0.0 pre-release version?

@AlexV525
Copy link
Contributor Author

I just upgraded my workspace dependency and it seems working. I used to think that a globally activated package would ignore the resolved version in the workspace, but now it appears not.

@spydon
Copy link
Collaborator

spydon commented Feb 11, 2025

I just upgraded my workspace dependency and it seems working. I used to think that a globally activated package would ignore the resolved version in the workspace, but now it appears not.

Ah yes, that is intentional, so that it always runs with the version that you've specified in the pubspec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants