feat: export message merging utilities to shared module #1635
+28
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazupon
approved these changes
Nov 16, 2023
kazupon
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only moves
deepCopyto@intlify/shared, at first I thought maybe it would be useful to move thehandleFlatJsonutility function as well but the changes would be more involved, maybe some other time.Due to moving the function the error formatting is not as easily accessible, as you can see
throw createI18nError(I18nErrorCodes.INVALID_VALUE)is replaced with a plainthrow new Error('Invalid value'), let me know if this should be different.Locally I tested importing this
deepCopyfunction in@nuxtjs/i18n, this will fix an issue after implementing (nuxt-modules/i18n#2476) which is nice, less code and fewer bugs! 😄Resolves #1634