Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oneDAL DPC interface detection #1990

Merged

Conversation

Alexsandruss
Copy link
Contributor

@Alexsandruss Alexsandruss commented Aug 6, 2024

Description

Update the way how sklearnex building script decides to enable DPC part:

  • Check for existence of onedal_dpc shared library
  • Check if NO_DPC env variable is not set

Solves #1981


Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • The unit tests pass successfully.
  • I have run it locally and tested the changes extensively.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.

Sorry, something went wrong.

@Alexsandruss
Copy link
Contributor Author

/intelci: run

2 similar comments
@Alexsandruss
Copy link
Contributor Author

/intelci: run

@Alexsandruss
Copy link
Contributor Author

/intelci: run

@Alexsandruss
Copy link
Contributor Author

/intelci: run

1 similar comment
@Alexsandruss
Copy link
Contributor Author

/intelci: run

@Alexsandruss Alexsandruss added enhancement New feature or request onedal iface dependencies Pull requests that update a dependency file labels Aug 6, 2024
@Alexsandruss Alexsandruss marked this pull request as ready for review August 6, 2024 19:59
@Alexsandruss Alexsandruss merged commit 6ee0e46 into uxlfoundation:main Aug 7, 2024
17 of 18 checks passed
Copy link
Contributor

@samir-nasibli samir-nasibli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with proposed changes, but it seems we are not testing the case, when NO_DPC is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request onedal iface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants