Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos instrumentation #515

Merged
merged 79 commits into from
Feb 15, 2024
Merged

Cosmos instrumentation #515

merged 79 commits into from
Feb 15, 2024

Conversation

Angith
Copy link
Contributor

@Angith Angith commented Dec 13, 2023

Changes

  • Added Cosmos span type in the core module.
  • Added instrumentation for Azure cosmos library.
  • Added integration tests for instacosmos

@Angith Angith self-assigned this Dec 13, 2023
@Angith Angith marked this pull request as draft December 13, 2023 04:23
Copy link
Contributor

@willianpc willianpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, man.
Keep up with the good work!
I added a few comments, I hope they can be helpful :)

instrumentation/instacosmos/containerClient.go Outdated Show resolved Hide resolved
instrumentation/instacosmos/dataBaseClient.go Outdated Show resolved Hide resolved
…os-instrumentation
Copy link
Contributor

@sanojsubran sanojsubran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @Angith !

instrumentation/instacosmos/README.md Outdated Show resolved Hide resolved
instrumentation/instacosmos/README.md Outdated Show resolved Hide resolved
supported_versions.md Outdated Show resolved Hide resolved
instrumentation/instacosmos/client.go Outdated Show resolved Hide resolved
example/cosmos/main.go Show resolved Hide resolved
@Angith Angith requested a review from sanojsubran February 5, 2024 05:51
Copy link
Contributor

@sanojsubran sanojsubran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Angith Angith force-pushed the cosmos-instrumentation branch from 9373c93 to 30fda9b Compare February 7, 2024 09:22
@Angith Angith force-pushed the cosmos-instrumentation branch from 50b2f03 to 66ba4ea Compare February 13, 2024 07:45
Angith and others added 5 commits February 13, 2024 13:28
…o-sensor into cosmos-instrumentation
Copy link
Member

@nithinputhenveettil nithinputhenveettil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Angith : Good job with the Sonarqube action. Added some minor changes.

supported_versions.md Outdated Show resolved Hide resolved
.github/workflows/coverage_run_and_upload.yml Outdated Show resolved Hide resolved
.github/workflows/sonarqube.yml Outdated Show resolved Hide resolved
Copy link
Member

@nithinputhenveettil nithinputhenveettil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

…os-instrumentation
@Angith Angith merged commit 1e29a94 into main Feb 15, 2024
10 checks passed
@Angith Angith deleted the cosmos-instrumentation branch February 15, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants