Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the TypedEvent conversion trait #1296

Merged
merged 2 commits into from
Apr 16, 2023
Merged

Expose the TypedEvent conversion trait #1296

merged 2 commits into from
Apr 16, 2023

Conversation

erwanor
Copy link
Collaborator

@erwanor erwanor commented Apr 16, 2023

This is a trivial API changes that exposes the tendermint::abci::event::TypedEvent marker trait.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

Sorry, something went wrong.

@codecov-commenter
Copy link

Codecov Report

Merging #1296 (907841a) into main (7955217) will increase coverage by 0.0%.
The diff coverage is n/a.

❗ Current head 907841a differs from pull request most recent head 442dc0c. Consider uploading reports for the commit 442dc0c to get more accurate results

@@          Coverage Diff          @@
##            main   #1296   +/-   ##
=====================================
  Coverage   64.2%   64.3%           
=====================================
  Files        271     271           
  Lines      24450   24450           
=====================================
+ Hits       15719   15722    +3     
+ Misses      8731    8728    -3     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erwanor erwanor merged commit ffbf990 into main Apr 16, 2023
@erwanor erwanor deleted the pub_type_event branch April 16, 2023 21:19
@erwanor erwanor mentioned this pull request Apr 16, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants