-
-
Notifications
You must be signed in to change notification settings - Fork 633
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: infernojs/inferno
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v8.1.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: infernojs/inferno
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v8.2.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 6 commits
- 82 files changed
- 2 contributors
Commits on May 13, 2023
-
Feature support for async prefetch in inferno-router (#1621)
* initial code * test beginning to work * working implementation with server side prefetch of loaders for SSR + rehydration * Fixed call to loader on first render * Fixed tests and added SSR and browser render * Moved SSR render test to inferno-server * Shrink and move * Use async await on server * Fix tests * renamed loaderData to initialData * Pass match params to async loader * Move first invokation of loader to lifecycle hook where it belongs * The condition can be solved through recursion for readability and reduced bundle size * Some tests working * Fixed regression bugs * Remove moved code * Improve typing and structure components to be more similar. Added switch test * Added demo application to test inferno-router with async loading * Added note on possibly false test * unused props * Demo: SSR (WIP) with resolving of loaders and using Parcel to transpile app on startup * Serve a proper SSR page to browser * SSR and hydration * Moved invocation of loader to Router * Fixed redirect issue that broke Switch tests * Notes for investigation of request * Demo using params in loader * Added test with params * First, dumbed down, try at adding request param and AbortController to allow cancelling inflight fetch on consecutive navigation WIP * Add test for abort signal on nav * Fix demo * Remove duplicate code in inferno-server * Simplify inherited code * Simplify again, Location objects return a href string * Change deprecated call, cleanup and and typing * Switch only renders first match so bailing out early * Don't traverse deeper if Route doesn't match * Removed loader code in Switch since it is handled by Router now * Change name to loaderData for individual match * Fixed SSR-rendering and added base argument to traverseLoaders to allow creating fully qualified URI from route path during SSR (if one wants to use it in the loader for hybrid endpoints) * Remove unused imports * Remove unreachable code * Unused types * Support subclassing Switch * Send cancel signal in demo * Fix issue where multiple nav clicks with loaders resolving out of order wouldn't end up on the last clicked route * Support typing response from loader data/error helpers * Use cross-env for Win-compat * Fix loader signature in AboutPage.tsx to allow calls to be cancelled * Fixed linting errors * Use custom resolver to allow parcel to choose correct bundle when packaging * Don't expose parentIsSwitch in exported function traverseLoaders since it is an implementation detail * Trigger rerender after promises have been resolved to make sure any pending renders are flushed * Update test to make sure we don't get false passing (I have broken the library code to verify that test fails) * Missed a Switch check * Remove parcel-resolver-inferno and use alias instead to pick transpiled dev version in demo * Remove need for esModuleInterop and isolatedModules * Update README for inferno-router * Update docs * Added link to demo and react-router loader docs * Call .json() and .text() on fetch result automatically * Rephrase part about missing features vs. react-router@6 * Clarified which headers aren't exposed * Bump versions * Cleaned up demo code and added clarification * Convert tests to Typescript * Updated package-lock.json * Store spy in variable to avoid type error and harmonise naming of said variables * Improve test of passing Location obj to Link * Fix linting errors * Final fix * Change type of `to` property so it is compatible with tests and parsePath
Configuration menu - View commit details
-
Copy full SHA for b1befe9 - Browse repository at this point
Copy the full SHA b1befe9View commit details
Commits on May 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4ec7f83 - Browse repository at this point
Copy the full SHA 4ec7f83View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4d396a - Browse repository at this point
Copy the full SHA f4d396aView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd520bb - Browse repository at this point
Copy the full SHA dd520bbView commit details -
Upgraded to Jasmine v5 and changed lowest testing target of FireFox to
91 due to limited support in Jasmine
Configuration menu - View commit details
-
Copy full SHA for a85716a - Browse repository at this point
Copy the full SHA a85716aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b300a89 - Browse repository at this point
Copy the full SHA b300a89View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v8.1.1...v8.2.0