Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal element group should be set up unconditionally #334

Open
inducer opened this issue Mar 6, 2024 · 0 comments
Open

Modal element group should be set up unconditionally #334

inducer opened this issue Mar 6, 2024 · 0 comments

Comments

@inducer
Copy link
Owner

inducer commented Mar 6, 2024

I agree, it would be ideal if the modal group was set up unconditionally. Unfortunately, I couldn't figure out a robust way to make that happen. Group factories are just callables, so discr_tag_to_group_factory[DISCR_TAG_BASE].order isn't guaranteed to work. We could try that (and give up if it doesn't work), which would make the situation incrementally better. (The previous version of the code unconditionally did that, so...) But it's not a bulletproof fix either. I would be OK with a PR that does this.

Originally posted by @inducer in #329 (comment)

@inducer inducer changed the title Modal element group should set up unconditionally Modal element group should be set up unconditionally Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant