Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to semver v7 #2808

Closed
beanow-at-crabnebula opened this issue Jun 27, 2023 · 1 comment
Closed

Upgrade to semver v7 #2808

beanow-at-crabnebula opened this issue Jun 27, 2023 · 1 comment

Comments

@beanow-at-crabnebula
Copy link

Semver disclosed this vulnerability: GHSA-c2qf-rxjj-qqgw

And there are no plans to backport the fix to v5/v6. npm/node-semver#576
This plugin is one of my transient dependencies depending on v6.

$ pnpm why semver@^6

devDependencies:
eslint-config-standard-with-typescript 34.0.1
├─┬ eslint-config-standard 17.0.0
│ └─┬ eslint-plugin-import 2.27.5 peer
│   └── semver 6.3.0
└─┬ eslint-plugin-import 2.27.5 peer
  └── semver 6.3.0

While it seems some community members offer to backport the fix, evidently the maintainers are reluctant to support older versions, given v7 was released in 2019. For future sanity of this plugin I'd encourage using the latest major version 😆

@ljharb
Copy link
Member

ljharb commented Jun 27, 2023

Like most CVEs, it's a false positive. We're not using new Range nor are we doing anything that wouldn't be a self-attack (ie, not an attack).

We can't ever bump the semver version because v7 drops support for engines we support, so unless the fix is backported to v6, it'll just have to remain a false positive.

Duplicate of #2803. Duplicate of #2804. Duplicate of #2805. Duplicate of #2806. Duplicate of #2807.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants