Fix a couple of no-cycle bugs
#2083
Merged
+48
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es of importing file
This fixes this situation:
`a.ts`:
```ts
import { foo } from './b'
```
`b.ts`:
```ts
import type { Bar } from './a'
```
Previously, `no-cycle` would have incorrectly reported a dependency cycle for the import in `a.ts`,
even though `b.ts` is only importing types from `a.ts`.
…mporting a value in Flow
This fixes this situation:
`a.js`:
```js
import { foo } from './b'
```
`b.js`:
```js
// @flow
import { bar, type Baz } from './a'
```
Previously, `no-cycle` would have not reported a dependency cycle for the import in `a.js`, even
though `b.js` is importing `bar`, which is not a type import, from `a.js`. This commit fixes that.
|
I am wondering when a new patch release will happen. I would like to use |
|
v2.23.3 is released. |
|
Thank you very much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes these two bugs:
There isn't an open issue for these, but these issues were relatively quick and easy for me to fix so I don't really mind if this PR gets rejected. Also, these bugs were introduced by me in #1974 (oops), so I wanted to fix them.
If you would like me to split these two bug fixes into two PRs, I'm more than happy to do that as well.