Improve performance of toJS (#1453) #1581
Closed
+15
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
leebyron
added a commit
that referenced
this pull request
Sep 18, 2018
Fixes #1453 commit b600bd7c56da9f71d19a035838523610d4c96c00 Author: Lee Byron <lee.byron@robinhood.com> Date: Tue Sep 18 12:54:40 2018 -0700 Further improvements commit 9c6395b4baba8a79b3b364d68a4909a26ce7b51c Merge: ca85e75 26ecbab Author: Lee Byron <lee.byron@robinhood.com> Date: Tue Sep 18 12:28:49 2018 -0700 Merge branch 'toJS-performance' of https://github.com/lukaswelinder/immutable-js into lukaswelinder-toJS-performance commit 26ecbab Author: Lukas Welinder <lukas@welinder.co> Date: Fri Aug 24 20:28:00 2018 -0700 Resolve issue w/ toJS handling structures that should become arrays commit 1c56169 Author: Lukas Welinder <lukas@welinder.co> Date: Fri Aug 24 20:11:42 2018 -0700 Resolve issue w/ toJS handling structures that should become arrays commit 0b44fad Author: Lukas Welinder <lukas@welinder.co> Date: Fri Aug 24 20:01:39 2018 -0700 Revert "Adjust type check approach for toJS performance fix" This reverts commit 0ca7f5d commit 0ca7f5d Author: Lukas Welinder <lukas@welinder.co> Date: Fri Aug 24 19:57:19 2018 -0700 Adjust type check approach for toJS performance fix commit 727bb23 Author: Lukas Welinder <lukas@welinder.co> Date: Fri Aug 24 19:38:01 2018 -0700 Improve performance of toJS (#1453)
|
Nice! I was able to speed things up a bit further by avoiding the Seq cast for collections and using the internal __iterate method instead of forEach - squash merge in 0082ff7 |
leebyron
added a commit
that referenced
this pull request
Sep 18, 2018
Fixes #1453 commit b600bd7c56da9f71d19a035838523610d4c96c00 Author: Lee Byron <lee.byron@robinhood.com> Date: Tue Sep 18 12:54:40 2018 -0700 Further improvements commit 9c6395b4baba8a79b3b364d68a4909a26ce7b51c Merge: ca85e75 26ecbab Author: Lee Byron <lee.byron@robinhood.com> Date: Tue Sep 18 12:28:49 2018 -0700 Merge branch 'toJS-performance' of https://github.com/lukaswelinder/immutable-js into lukaswelinder-toJS-performance commit 26ecbab Author: Lukas Welinder <lukas@welinder.co> Date: Fri Aug 24 20:28:00 2018 -0700 Resolve issue w/ toJS handling structures that should become arrays commit 1c56169 Author: Lukas Welinder <lukas@welinder.co> Date: Fri Aug 24 20:11:42 2018 -0700 Resolve issue w/ toJS handling structures that should become arrays commit 0b44fad Author: Lukas Welinder <lukas@welinder.co> Date: Fri Aug 24 20:01:39 2018 -0700 Revert "Adjust type check approach for toJS performance fix" This reverts commit 0ca7f5d commit 0ca7f5d Author: Lukas Welinder <lukas@welinder.co> Date: Fri Aug 24 19:57:19 2018 -0700 Adjust type check approach for toJS performance fix commit 727bb23 Author: Lukas Welinder <lukas@welinder.co> Date: Fri Aug 24 19:38:01 2018 -0700 Improve performance of toJS (#1453)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1453, significantly improving performance of
toJSmethod; more details can be found in my comment on that issue.It might be worth adding a performance regression test for the
toJSmethod.