Added optional value in first and last #1553 #1556
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
yasserhussain1110
changed the title
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Looks solid to me! |
__tests__/Seq.ts
Outdated
|
|
||
| it('has a default first value', () => { | ||
| expect(Seq().last({})).toEqual({}); | ||
| }); |
There was a problem hiding this comment.
Should probably also have a test that ensures that calling first and last on an empty Seq with no default set will return undefined. Only to make sure the behavior is consistent with the past.
|
@rgbkrk Made the required changes. |
|
Add this optional argument to the type definitions ( |
There was a problem hiding this comment.
Good call from @asazernik:
Add this optional argument to the type definitions (
type-definitions/Immutable.d.ts and type-definitions/immutable.js.flow) and describe it in the docs (the javadoc-ish comments intype-definitions/Immutable.d.ts).
|
Added type definitions. Please let me know if further changes are required. |
|
Note that this PR leads to new type errors since |
This PR fixes #1553
Now you can call
Seqlike so -