Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't use .mjs file for react-native, which isn't supported by default. Fixes #1058 #1065 #1075

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

mweststrate
Copy link
Collaborator

pre-published as immer@10.0.3-beta

@github-actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 6285188608

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.793%

Totals Coverage Status
Change from base Build 4929177933: 0.0%
Covered Lines: 646
Relevant Lines: 647

💛 - Coveralls

@markerikson
Copy link
Contributor

It looks like RN 0.72 will help with this by finally supporting exports properly, but yeah, this might be necessary to support the rest of the ecosystem until they catch up:

@markerikson
Copy link
Contributor

Looking at https://facebook.github.io/metro/docs/package-exports/ , it sounds like Metro currently looks for "react-native", "browser", and "main":

I see that Immer actually does list "react-native". The Redux packages don't, but do list "main", and in our current Redux betas, I am pointing "main" to that similar legacy-esm.js file. So, I think we've got the same net result.

@mweststrate mweststrate merged commit f6736a4 into main Oct 2, 2023
2 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

🎉 This PR is included in version 10.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants