Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I need BarChart & Linechart's extraLinesData #476

Closed
jpoh281 opened this issue Oct 21, 2020 · 14 comments
Closed

I need BarChart & Linechart's extraLinesData #476

jpoh281 opened this issue Oct 21, 2020 · 14 comments
Labels
Bar Chart enhancement New feature or request good first issue Good for newcomers

Comments

@jpoh281
Copy link

jpoh281 commented Oct 21, 2020

image
+
image

and I use barchart in SingleChildScrollview.
How can I adjust width interver ?

@imaNNeo
Copy link
Owner

imaNNeo commented Oct 23, 2020

Sorry I didn't understand!

@jpoh281
Copy link
Author

jpoh281 commented Oct 23, 2020

I understand this package, bar chart can't extraLines.
but I want draw extraLine

@imaNNeo
Copy link
Owner

imaNNeo commented Oct 24, 2020

Aha got it.

@imaNNeo imaNNeo added Bar Chart enhancement New feature or request labels Oct 24, 2020
@matbujnowicz
Copy link

Screenshot 2020-11-10 at 15 18 04

I think I have the same problem. We need a dashed horizontal line to show the average.

If you are planning to add this feature, may I ask in how long I could expect it? As I need to know whether I should think of some Stack workaround or I should just wait a bit.

Thanks for the great work anyway!

@imaNNeo
Copy link
Owner

imaNNeo commented Nov 10, 2020

I understand you need it. But keep in mind that I have my personal life and I have to spend time on my personal stuff. I have a little time for maintaining this repo or something like that.
Donation motivates me to work more here (as you know everyone needs to make money somehow).
Also, I suggest you make your hands dirty and read the source code. Then you can make your merge request.
Thanks, regards!

@DooRooSA
Copy link

I've started looking at the code to add this feature, tackling this as my first-ever contribution to OSS. The ExtraLinesData class is defined in line_chart_data.dart . We can reuse this class for the BarChart as well. Just want to find out whether I leave the class in that file, because my gut feel is that it should move to a more generic file. I'm just not sure where to move it to

@imaNNeo
Copy link
Owner

imaNNeo commented Apr 20, 2022

I've started looking at the code to add this feature, tackling this as my first-ever contribution to OSS. The ExtraLinesData class is defined in line_chart_data.dart . We can reuse this class for the BarChart as well. Just want to find out whether I leave the class in that file, because my gut feel is that it should move to a more generic file. I'm just not sure where to move it to

Hi @DooRooSA.
Sorry for my late answer.
I'm very happy that you are trying to do your first-ever contribution.
It seems someone else created a PR for this. But it doesn't mean that you cannot implement it in your way.
I will merge a branch that will be ready faster. Or maybe you can try on another issue.

@DooRooSA
Copy link

hi @imaNNeoFighT,

No worries, if it's been done already, it'll be better if I carry on with something else. Have a great day!

@imaNNeo
Copy link
Owner

imaNNeo commented Apr 21, 2022

Have a great day!

@FriendlyNeighbor
Copy link

was this successfully merged?

@JoshMart
Copy link
Contributor

It appears as if this has not been resolved yet. It would be very useful for me as well to draw mean and standard deviation horizontally on a bar chart.

@imaNNeo
Copy link
Owner

imaNNeo commented Jan 16, 2023

No. The PR contributor was not responsive and I just closed the PR.
Now everyone can take this task and implement it.

@JoshMart
Copy link
Contributor

Thanks for the update. I am working on enabling this feature and using code from previous PRs as a starting point.

@imaNNeo
Copy link
Owner

imaNNeo commented Jan 26, 2023

This feature is added in 0.60.0. Check it out!

@imaNNeo imaNNeo closed this as completed Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bar Chart enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants