config#Load(): Let error indicate absence of the default config file
#112
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the validation of the configuration fails, `config#Load()` currently only returns an error message about the failed validation. However, the default configuration file may be missing, which itself is not an error in the validation process, as `config#Load()` supports loading configurations from both YAML and environment variables. In order to obtain a meaningful error message, `config#Load()` now returns a combined error message indicating that the default configuration file is missing, which can be ignored if the configuration is supposed to be provided entirely via environment variables.
oxzi
approved these changes
Mar 5, 2025
3 tasks
lippserd
deleted the
config-load-error-message-if-config-file-is-default-and-does-not-exist
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the validation of the configuration fails,
config#Load()currently only returns an error message about the failed validation. However, the default configuration file may be missing, which itself is not an error in the validation process, asconfig#Load()supports loading configurations from both YAML and environment variables. In order to obtain a meaningful error message,config#Load()now returns a combined error message indicating that the default configuration file is missing, which can be ignored if the configuration is supposed to be provided entirely via environment variables.