Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add codeQuality and build jobs #2146

Merged
merged 2 commits into from Feb 24, 2024

Conversation

marcalexiei
Copy link
Member

  • Replaced prettier script with format and format:fix script
  • Added a codeQuality job as described in the issue (Ideas: improve CI #2142).
  • In addition I also added a build job to assure that also build runs smoothly.
  • pretest script no longer runs lint script

Due to the previous changes I renamed the lint_and_test workflow in CI to better reflect its purpose.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

@marcalexiei marcalexiei mentioned this pull request Feb 23, 2024
2 tasks
@coveralls
Copy link

coveralls commented Feb 23, 2024

Coverage Status

coverage: 96.191%. remained the same
when pulling 8682725 on marcalexiei:feature/ci-format-job
into 14598e2 on i18next:master.

@adrai
Copy link
Member

adrai commented Feb 23, 2024

Can you also adapt the README because of the github worfklow renaming? https://github.com/i18next/i18next/blob/master/README.md?plain=1#L3

btw: does the lint script not run anymore completely?

@marcalexiei
Copy link
Member Author

Can you also adapt the README because of the github worfklow renaming?

Sure!


btw: does the lint script not run anymore completely?

The lint script is now executed explicitly inside codeQuality job.
If you wish we could run it also on pre-push hook via husky.

@adrai
Copy link
Member

adrai commented Feb 24, 2024

Yes, maybe also pre-push would be good.

@marcalexiei
Copy link
Member Author

I also added format script within the pre-push hook.
Better to have them fail locally than while running an action so you can have feedback quicker.

@adrai adrai merged commit 3a247e1 into i18next:master Feb 24, 2024
8 checks passed
@adrai
Copy link
Member

adrai commented Feb 24, 2024

thx a lot

@marcalexiei marcalexiei deleted the feature/ci-format-job branch February 24, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants