types: support nested keys in InterpolationMap
#2140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2014
Now
InterpolatorMap
parse the keys retrieved viaParseInterpolationValues
creating a mapped type instead of a aRecord<string, unknown>
.Here is a typescript playground where all types involved are available:
Ret
type)From my basic test this shouldn't affect performance very much,
but I haven't conducted deep performance test so far.
Unfortunately this I haven't a real app scenario to test this since
I am not using JSONs for translation so all my values are
string
.If someone with the issue could test this it would be great.
Checklist
npm run test
Off topic
@adrai sorry if I write here but I don't know a better place 馃槄
Thanks for the invite! I have a few ideas to share about some changes to the library and repo,
if is ok for you I'll open an issue with more details in the upcoming days.