Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tls): Small refactoring #1487

Merged
merged 2 commits into from Sep 1, 2023
Merged

chore(tls): Small refactoring #1487

merged 2 commits into from Sep 1, 2023

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Aug 29, 2023

Motivation

Small refactorings of tonic's tls config.

Solution

  • Removes rustls crate from dependencies as it is not used.
  • Updates to rustls-native-certs 0.6.3 from 0.6.1 and use its AsRef<[u8]> for Certificate.
  • Uses AsRef<u8> for tonic's Certificate struct instead of slice syntax.

@tottoto tottoto changed the title chore(tls): Simplify implementation chore(tls): Small refactoring Aug 29, 2023
djc
djc approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by review: LGTM!

@LucioFranco LucioFranco added this pull request to the merge queue Sep 1, 2023
Merged via the queue into hyperium:master with commit e7744ec Sep 1, 2023
16 checks passed
@tottoto tottoto deleted the refactor-transport-tls branch September 1, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tottoto @djc @LucioFranco