Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tonic-build: Builder: add {enum,message}_attributes #1234

Merged
merged 3 commits into from Jan 17, 2023
Merged

tonic-build: Builder: add {enum,message}_attributes #1234

merged 3 commits into from Jan 17, 2023

Conversation

g0hl1n
Copy link
Contributor

@g0hl1n g0hl1n commented Jan 11, 2023

Motivation

The latest prost-build introduced enum_attribute and message_attribute configurations. We should support it.

Solution

Update prost-build to v0.11.6 and add the enum_attribute and message_attribute forwarders.

Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
@LucioFranco
Copy link
Member

@g0hl1n
Copy link
Contributor Author

g0hl1n commented Jan 11, 2023

ACK. Will update the PR accordingly.

@g0hl1n g0hl1n changed the title tonic-build: Builder: add enum_attributes tonic-build: Builder: add {enum,message}_attributes Jan 12, 2023
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
@g0hl1n
Copy link
Contributor Author

g0hl1n commented Jan 12, 2023

Forgot to run cargo fmt on the message_attributes patch. I've updated the PR. Sorry for missing it on the first try.

@LucioFranco LucioFranco merged commit ff642f9 into hyperium:master Jan 17, 2023
@g0hl1n g0hl1n deleted the tonic-build_add_enum_attributes branch January 17, 2023 19:57
@Hallot
Copy link

Hallot commented Jan 26, 2023

Thank you g0hl1n.
@LucioFranco Would it possible to have a new release soon with this feature? That would be most appreciated, thank you.

@dado0583
Copy link

dado0583 commented Feb 2, 2023

+1. Would love to use this to add the derive_builder to the message generated code so that I can generate protos without explicitly providing every field (https://crates.io/crates/derive_builder)

Is there anything I can do to help get the release out @g0hl1n ?

(cc @samiam376)

@LucioFranco
Copy link
Member

It might be a bit to get a release out I believe there are some breaking changes on master and I am traveling over the next few weeks (and was just travelling). So I will need some time to sort that out. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants