fix(http1): add internal limit for chunked extensions #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The chunked transfer-encoding allows for extensions within the header of each chunk. hyper currently ignores the extension bytes. Sending large amounts of bytes in the extensions will waste CPU reaing and skipping them. This change adds an internal limit to how many bytes will be read and ignored in a single body, before returning an error. Reported-by: Bartek Nowotarski <bartek@nowotarski.info>
seanmonstar
force-pushed
the
fix-chunked-boundless-extensions
branch
from
48f48da
to
ba8faf4
Compare
seanmonstar
added a commit
that referenced
this pull request
Dec 18, 2023
The chunked transfer-encoding allows for extensions within the header of each chunk. hyper currently ignores the extension bytes. Sending large amounts of bytes in the extensions will waste CPU reaing and skipping them. This change adds an internal limit to how many bytes will be read and ignored in a single body, before returning an error. Reported-by: Bartek Nowotarski <bartek@nowotarski.info>
seanmonstar
added a commit
that referenced
this pull request
Dec 18, 2023
The chunked transfer-encoding allows for extensions within the header of each chunk. hyper currently ignores the extension bytes. Sending large amounts of bytes in the extensions will waste CPU reaing and skipping them. This change adds an internal limit to how many bytes will be read and ignored in a single body, before returning an error. Reported-by: Bartek Nowotarski <bartek@nowotarski.info>
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this pull request
Jan 12, 2024
The chunked transfer-encoding allows for extensions within the header of each chunk. hyper currently ignores the extension bytes. Sending large amounts of bytes in the extensions will waste CPU reaing and skipping them. This change adds an internal limit to how many bytes will be read and ignored in a single body, before returning an error. Reported-by: Bartek Nowotarski <bartek@nowotarski.info>
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this pull request
Jan 16, 2024
The chunked transfer-encoding allows for extensions within the header of each chunk. hyper currently ignores the extension bytes. Sending large amounts of bytes in the extensions will waste CPU reaing and skipping them. This change adds an internal limit to how many bytes will be read and ignored in a single body, before returning an error. Reported-by: Bartek Nowotarski <bartek@nowotarski.info> Signed-off-by: Sven Pfennig <s.pfennig@reply.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chunked transfer-encoding allows for extensions within the header of each chunk. hyper currently ignores the extension bytes. Sending large amounts of bytes in the extensions will waste CPU reaing and skipping them.
This change adds an internal limit to how many bytes will be read and ignored in a single body, before returning an error.
Reported-by: Bartek Nowotarski bartek@nowotarski.info