feat(upgrade): allow http upgrades with any body type

luqmana · seanmonstar · commit ab469eb3c6cd · 2021-11-03T11:40:33.000-07:00
Allow using `Request&lt;T&gt;`/`Response&lt;T&gt;` for any given T with
`upgrade::on` instead of just restricting it to `hyper::Body`.
diff --git a/src/upgrade.rs b/src/upgrade.rs
@@ -258,31 +258,31 @@ mod sealed {
         fn on_upgrade(self) -> OnUpgrade;
     }
 
-    impl CanUpgrade for http::Request<crate::Body> {
+    impl<B> CanUpgrade for http::Request<B> {
         fn on_upgrade(mut self) -> OnUpgrade {
             self.extensions_mut()
                 .remove::<OnUpgrade>()
                 .unwrap_or_else(OnUpgrade::none)
         }
     }
 
-    impl CanUpgrade for &'_ mut http::Request<crate::Body> {
+    impl<B> CanUpgrade for &'_ mut http::Request<B> {
         fn on_upgrade(self) -> OnUpgrade {
             self.extensions_mut()
                 .remove::<OnUpgrade>()
                 .unwrap_or_else(OnUpgrade::none)
         }
     }
 
-    impl CanUpgrade for http::Response<crate::Body> {
+    impl<B> CanUpgrade for http::Response<B> {
         fn on_upgrade(mut self) -> OnUpgrade {
             self.extensions_mut()
                 .remove::<OnUpgrade>()
                 .unwrap_or_else(OnUpgrade::none)
         }
     }
 
-    impl CanUpgrade for &'_ mut http::Response<crate::Body> {
+    impl<B> CanUpgrade for &'_ mut http::Response<B> {
         fn on_upgrade(self) -> OnUpgrade {
             self.extensions_mut()
                 .remove::<OnUpgrade>()

Original file line number	Diff line number	Diff line change
`@@ -258,31 +258,31 @@ mod sealed {`
`258`	`258`	`fn on_upgrade(self) -> OnUpgrade;`
`259`	`259`	`}`
`260`	`260`
`261`		`- impl CanUpgrade for http::Request<crate::Body> {`
	`261`	`+ impl<B> CanUpgrade for http::Request<B> {`
`262`	`262`	`fn on_upgrade(mut self) -> OnUpgrade {`
`263`	`263`	`self.extensions_mut()`
`264`	`264`	`.remove::<OnUpgrade>()`
`265`	`265`	`.unwrap_or_else(OnUpgrade::none)`
`266`	`266`	`}`
`267`	`267`	`}`
`268`	`268`
`269`		`- impl CanUpgrade for &'_ mut http::Request<crate::Body> {`
	`269`	`+ impl<B> CanUpgrade for &'_ mut http::Request<B> {`
`270`	`270`	`fn on_upgrade(self) -> OnUpgrade {`
`271`	`271`	`self.extensions_mut()`
`272`	`272`	`.remove::<OnUpgrade>()`
`273`	`273`	`.unwrap_or_else(OnUpgrade::none)`
`274`	`274`	`}`
`275`	`275`	`}`
`276`	`276`
`277`		`- impl CanUpgrade for http::Response<crate::Body> {`
	`277`	`+ impl<B> CanUpgrade for http::Response<B> {`
`278`	`278`	`fn on_upgrade(mut self) -> OnUpgrade {`
`279`	`279`	`self.extensions_mut()`
`280`	`280`	`.remove::<OnUpgrade>()`
`281`	`281`	`.unwrap_or_else(OnUpgrade::none)`
`282`	`282`	`}`
`283`	`283`	`}`
`284`	`284`
`285`		`- impl CanUpgrade for &'_ mut http::Response<crate::Body> {`
	`285`	`+ impl<B> CanUpgrade for &'_ mut http::Response<B> {`
`286`	`286`	`fn on_upgrade(self) -> OnUpgrade {`
`287`	`287`	`self.extensions_mut()`
`288`	`288`	`.remove::<OnUpgrade>()`