Skip to content

Commit 7206fe3

Browse files
committedFeb 5, 2024
fix(rt): Sleep::downcast_mut_pin() no longer extend lifetime
This lifetime extension was a mistake. Closes #3556 BREAKING CHANGE: The returned lifetime from `Sleep::downcast_mut_pin()` is no longer `'static`. This shouldn't affect most usage. This sort of breaking change is needed because it is _wrong_.
1 parent 90eb95f commit 7206fe3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎src/rt/timer.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ impl dyn Sleep {
104104
}
105105

106106
/// Downcast a pinned &mut Sleep object to its original type
107-
pub fn downcast_mut_pin<T>(self: Pin<&mut Self>) -> Option<Pin<&'static mut T>>
107+
pub fn downcast_mut_pin<T>(self: Pin<&mut Self>) -> Option<Pin<&mut T>>
108108
where
109109
T: Sleep + 'static,
110110
{

1 commit comments

Comments
 (1)

github-actions[bot] commented on Feb 5, 2024

@github-actions[bot]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'end_to_end'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 7206fe3 Previous: 90eb95f Ratio
http2_parallel_x10_req_10kb_100_chunks_adaptive_window 24776299 ns/iter (± 18371731) 7869253 ns/iter (± 117771) 3.15

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.