Skip to content

Commit 48e70c6

Browse files
Michael-J-Wardseanmonstar
authored andcommittedDec 28, 2022
feat(server): remove http1_ method prefixes from server::conn::http2::Builder
Refs: #3085
1 parent 669df21 commit 48e70c6

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed
 

‎examples/http_proxy.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
3131

3232
tokio::task::spawn(async move {
3333
if let Err(err) = http1::Builder::new()
34-
.http1_preserve_header_case(true)
35-
.http1_title_case_headers(true)
34+
.preserve_header_case(true)
35+
.title_case_headers(true)
3636
.serve_connection(stream, service_fn(proxy))
3737
.with_upgrades()
3838
.await

‎src/server/conn/http1.rs

+6-6
Original file line numberDiff line numberDiff line change
@@ -224,15 +224,15 @@ impl Builder {
224224
/// detects an EOF in the middle of a request.
225225
///
226226
/// Default is `false`.
227-
pub fn http1_half_close(&mut self, val: bool) -> &mut Self {
227+
pub fn half_close(&mut self, val: bool) -> &mut Self {
228228
self.h1_half_close = val;
229229
self
230230
}
231231

232232
/// Enables or disables HTTP/1 keep-alive.
233233
///
234234
/// Default is true.
235-
pub fn http1_keep_alive(&mut self, val: bool) -> &mut Self {
235+
pub fn keep_alive(&mut self, val: bool) -> &mut Self {
236236
self.h1_keep_alive = val;
237237
self
238238
}
@@ -243,7 +243,7 @@ impl Builder {
243243
/// Note that this setting does not affect HTTP/2.
244244
///
245245
/// Default is false.
246-
pub fn http1_title_case_headers(&mut self, enabled: bool) -> &mut Self {
246+
pub fn title_case_headers(&mut self, enabled: bool) -> &mut Self {
247247
self.h1_title_case_headers = enabled;
248248
self
249249
}
@@ -261,7 +261,7 @@ impl Builder {
261261
/// Note that this setting does not affect HTTP/2.
262262
///
263263
/// Default is false.
264-
pub fn http1_preserve_header_case(&mut self, enabled: bool) -> &mut Self {
264+
pub fn preserve_header_case(&mut self, enabled: bool) -> &mut Self {
265265
self.h1_preserve_header_case = enabled;
266266
self
267267
}
@@ -270,7 +270,7 @@ impl Builder {
270270
/// transmit the entire header within this time, the connection is closed.
271271
///
272272
/// Default is None.
273-
pub fn http1_header_read_timeout(&mut self, read_timeout: Duration) -> &mut Self {
273+
pub fn header_read_timeout(&mut self, read_timeout: Duration) -> &mut Self {
274274
self.h1_header_read_timeout = Some(read_timeout);
275275
self
276276
}
@@ -287,7 +287,7 @@ impl Builder {
287287
///
288288
/// Default is `auto`. In this mode hyper will try to guess which
289289
/// mode to use
290-
pub fn http1_writev(&mut self, val: bool) -> &mut Self {
290+
pub fn writev(&mut self, val: bool) -> &mut Self {
291291
self.h1_writev = Some(val);
292292
self
293293
}

‎src/server/conn/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
//! let (tcp_stream, _) = tcp_listener.accept().await?;
3131
//! tokio::task::spawn(async move {
3232
//! if let Err(http_err) = http1::Builder::new()
33-
//! .http1_keep_alive(true)
33+
//! .keep_alive(true)
3434
//! .serve_connection(tcp_stream, service_fn(hello))
3535
//! .await {
3636
//! eprintln!("Error while serving HTTP connection: {}", http_err);

‎tests/server.rs

+5-5
Original file line numberDiff line numberDiff line change
@@ -1247,7 +1247,7 @@ async fn http1_allow_half_close() {
12471247

12481248
let (socket, _) = listener.accept().await.unwrap();
12491249
http1::Builder::new()
1250-
.http1_half_close(true)
1250+
.half_close(true)
12511251
.serve_connection(
12521252
socket,
12531253
service_fn(|_| {
@@ -1274,7 +1274,7 @@ async fn disconnect_after_reading_request_before_responding() {
12741274

12751275
let (socket, _) = listener.accept().await.unwrap();
12761276
http1::Builder::new()
1277-
.http1_half_close(false)
1277+
.half_close(false)
12781278
.serve_connection(
12791279
socket,
12801280
service_fn(|_| {
@@ -1370,7 +1370,7 @@ async fn header_read_timeout_slow_writes() {
13701370
let (socket, _) = listener.accept().await.unwrap();
13711371
let conn = http1::Builder::new()
13721372
.timer(TokioTimer)
1373-
.http1_header_read_timeout(Duration::from_secs(5))
1373+
.header_read_timeout(Duration::from_secs(5))
13741374
.serve_connection(
13751375
socket,
13761376
service_fn(|_| {
@@ -1445,7 +1445,7 @@ async fn header_read_timeout_slow_writes_multiple_requests() {
14451445
let (socket, _) = listener.accept().await.unwrap();
14461446
let conn = http1::Builder::new()
14471447
.timer(TokioTimer)
1448-
.http1_header_read_timeout(Duration::from_secs(5))
1448+
.header_read_timeout(Duration::from_secs(5))
14491449
.serve_connection(
14501450
socket,
14511451
service_fn(|_| {
@@ -2839,7 +2839,7 @@ impl ServeOptions {
28392839
.serve_connection(stream, service).await.unwrap();
28402840
} else {
28412841
http1::Builder::new()
2842-
.http1_keep_alive(_options.keep_alive)
2842+
.keep_alive(_options.keep_alive)
28432843
.pipeline_flush(_options.pipeline)
28442844
.serve_connection(stream, service).await.unwrap();
28452845
}

0 commit comments

Comments
 (0)
Please sign in to comment.