Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

h3-quinn: fix usage of a private StreamId field #290

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Conversation

seanmonstar
Copy link
Member

We were accessing a field that was doc(hidden). A new version of quinn-proto made this field actually private, but made it possible to convert a stream ID into a u64.

@seanmonstar seanmonstar force-pushed the quinn-stream-id branch 3 times, most recently from ad58032 to b98a20e Compare March 18, 2025 15:39
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might want to include a version bump?

@seanmonstar
Copy link
Member Author

I do version bumps as part of a release commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants