Add a message for EOF-related broken pipe errors #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nox
force-pushed
the
broken-pipe-messages
branch
3 times, most recently
from
9304876
to
8b1f01b
Compare
nox
force-pushed
the
broken-pipe-messages
branch
from
8b1f01b
to
72f735a
Compare
|
@seanmonstar Can I get a review pls? |
nox
force-pushed
the
broken-pipe-messages
branch
2 times, most recently
from
bcf1724
to
0af2c67
Compare
LucioFranco
approved these changes
Feb 14, 2023
src/proto/streams/state.rs
Outdated
| self.inner = Closed(Cause::Error( | ||
| io::Error::new( | ||
| io::ErrorKind::BrokenPipe, | ||
| "stream closed because of broken pipe", |
There was a problem hiding this comment.
Shouldn't it be because of a broken pipe?
|
What would be the best error message here? |
nox
force-pushed
the
broken-pipe-messages
branch
from
0af2c67
to
e470a6d
Compare
|
Ci Failing? |
It's quite confusing from production logs when all I get is "broken pipe" and I don't know which path was taken for that error to be logged.
nox
force-pushed
the
broken-pipe-messages
branch
from
e470a6d
to
dcca27c
Compare
seanmonstar
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's quite confusing from production logs when all I get is "broken pipe" and I don't know which path was taken for that error to be logged.