Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad feedback on reset stream #592

Open
Icelk opened this issue Jan 3, 2022 · 3 comments
Open

Bad feedback on reset stream #592

Icelk opened this issue Jan 3, 2022 · 3 comments

Comments

@Icelk
Copy link

Icelk commented Jan 3, 2022

When a stream is reset before calling send_response, the error returned is a Error::User.

That variant doesn't contain any data telling what caused the issue. I propose adding some form of feedback to at least the debug implementation.

This is the file where the error is returned, without any context.

@seanmonstar
Copy link
Member

That sounds like a good improvement to me!

@Icelk
Copy link
Author

Icelk commented Jan 4, 2022

This seems like quite a large change, since we'd have to change the (Error)Kind::User variant.

What data should we attach? Another enum containing the context of the user error?

I'd gladly open a PR.

@Icelk
Copy link
Author

Icelk commented Apr 20, 2022

@seanmonstar Any feedback? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants