Exposes Kendra result item DocumentAttributes in the document metadata #7781
+127
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
the
🤖:improvement
wnleao
force-pushed
the
kendra-expose-document-attributes-metadata
branch
from
6c45518 to
5738df0
Compare
|
I will propose more points of refactoring soon in separate PRs/issues. Thank you in advance for your review and all the work moving this forward! |
|
@3coins |
- Refactors retriever by providing a ResultItem base class in order to avoid duplicate code; - Exposes the ResultItem DocumentAttributes as document metadata with key 'document_attributes'.
Co-authored-by: Piyush Jain <piyushjain@duck.com>
wnleao
force-pushed
the
kendra-expose-document-attributes-metadata
branch
from
9237bd1 to
63c44a0
Compare
baskaryan
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Some use cases depend on specific document attributes returned by the retriever in order to improve the quality of the overall completion and adjust what will be displayed to the user. For the sake of consistency, we need to expose the DocumentAttributes as document metadata so we are sure that we are using the values returned by the kendra request issued by langchain.
I would appreciate your review @3coins @hupe1980 @dev2049. Thank you in advance!
References