fix: pgvector search_type of similarity_score_threshold not working

[wwwbbb8510]

• Description: VectorStoreRetriever->similarity_score_threshold with search_type of "similarity_score_threshold" not working with the following two minor issues,
• Issue: 1. In line 237 of vectorstores/base.py, "score_threshold" is passed to _similarity_search_with_relevance_scores as in the kwargs, while score_threshold is not a valid argument of this method. As a fix, before calling _similarity_search_with_relevance_scores, score_threshold is popped from kwargs. 2. In line 596 to 607 of vectorstores/pgvector.py, it's checking the distance_strategy against the string in Enum. However, self.distance_strategy will get the property of distance_strategy from line 316, where the callable function is passed. To solve this issue, self.distance_strategy is changed to self._distance_strategy to avoid calling the property method.,
• Dependencies: No,
• Tag maintainer: @rlancemartin, @eyurtsev,
• Twitter handle: No

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
langchain	⬜️ Ignored (Inspect)			Jul 16, 2023 8:47am

[wwwbbb8510]

Hi @rlancemartin and @eyurtsev
As all checks have passed, what will be the estimated time frame for the pull request to be merged. I really need this in our application on prod. If this can't be merged soon, we will need to find alternative approach to use it on prod.
Looking forward to your reply.
Thanks

[baskaryan]

thanks @wwwbbb8510!