Update base chain type hints #7680
Merged
+16
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses langchain-ai#7578. `run()` can return dictionaries, Pydantic objects or strings, so the type hints should reflect that. See the chain from `create_structured_output_chain` for an example of a non-string return type from `run()`.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
🤖:improvement
|
thanks @stakodiak! |
bdonkey
added a commit
to bdonkey/langchain
that referenced
this pull request
Jul 26, 2023
* master: (496 commits) New enterprise support form (langchain-ai#8254) Add LLMChain example of memory with chat models (langchain-ai#8250) Update Broken Links (langchain-ai#8247) Remove operator overloading for BaseMessage (langchain-ai#8245) Update references (langchain-ai#8243) Bug Fix langchain-ai#6462 (langchain-ai#8241) bump 242 (langchain-ai#8238) Add/faiss test score threshold (langchain-ai#8224) use logger instead of logging (langchain-ai#8225) Refactored `requests` (langchain-ai#8203) Update Integrations links (langchain-ai#8206) Update base chain type hints (langchain-ai#7680) feat: temp fixed Could not parse LLM output on agents folder (langchain-ai#7746) add Hybrid retriever that not require any external service (langchain-ai#8108) Fixed grammar in LLM models documentation (langchain-ai#8210) Update supabase.py, add filter to query (matches latest supabase docs & js) (langchain-ai#7721) Fixed sparql SELECT and UPDATE query function (langchain-ai#7758) Add async support for transform chain (langchain-ai#8205) Added stop sequence support to replicate (langchain-ai#8107) Add etherscan document loader (langchain-ai#7943) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #7578.
run()can return dictionaries, Pydantic objects or strings, so the type hints should reflect that. See the chain fromcreate_structured_output_chainfor an example of a non-string return type fromrun().I've updated the BaseLLMChain return type hint from
strtoAny. Although, the differences betweenrun()and__call__()seem less clear now.CC: @baskaryan