Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Just changing the registration event and redrawing the echart will cause the chart to shake #447

Closed
iitodo opened this issue Aug 8, 2021 · 1 comment
Closed

Just changing the registration event and redrawing the echart will cause the chart to shake #447

iitodo opened this issue Aug 8, 2021 · 1 comment

Comments

@iitodo
Copy link
Contributor

iitodo commented Aug 8, 2021

Just changing the registration event and redrawing the echart will cause the chart to shake

There is a problem with the following code
src/core.tsx
image
@hustcc
Copy link
Owner

hustcc commented Oct 29, 2021

useMemo to cache the onevents functions.

@hustcc hustcc closed this as completed Oct 29, 2021
hustcc pushed a commit that referenced this issue Mar 5, 2025
@iitodo
Fix #446, #447 issues. 1) Only refresh the events bound by echart whe…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
fcc1268 
…n the event changes. 2) If the style or classname changes, it's more reasonable to refresh the data after performing charts.resize first. (#444)

* 1. 仅事件变化时只刷新echart绑定的事件；2. 如果style或者className变化，先进行echarts.resize再刷新数据更合理

* 检视意见修改

* 增加测试用例

---------

Co-authored-by: Wang Sen <13710729@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hustcc @iitodo