Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update descriptions and structure for Toggle/Group #589

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

ronkeiser
Copy link
Contributor

Currently, the descriptions for Toggle and Toggle Group are reversed!

image image

Also, the structure for Toggle includes Toggle.Thumb and Toggle.Input components which do not exist:

<script lang="ts">
  import { Toggle } from "bits-ui";
</script>
 
<Toggle.Root>
  <Toggle.Thumb />
  <Toggle.Input />
</Toggle.Root>

This PR switches the descriptions and removes the extraneous components from the structure:

<script lang="ts">
  import { Toggle } from "bits-ui";
</script>
 
<Toggle.Root/>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

changeset-bot bot commented Jun 28, 2024

⚠️ No Changeset found

Latest commit: 5b0523f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 28, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
bits-ui ✅ Ready (View Log) Visit Preview 5b0523f

Copy link
Owner

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, can't believe I or someone else haven't noticed this yet.

Thank you!

@huntabyte huntabyte changed the title Update descriptions and structure for Toggle and Toggle Group docs: Update descriptions and structure for Toggle/Group Jun 28, 2024
@huntabyte huntabyte merged commit 75b1402 into huntabyte:main Jun 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants