ModernBert: reuse GemmaRotaryEmbedding via modular + Integration tests #35459
+178
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Jan 9, 2025
| class ModernBertRotaryEmbedding(GemmaRotaryEmbedding): | ||
| def __init__(self, config: ModernBertConfig, dim: int, base: float, device: Optional[torch.device] = None): | ||
| super().__init__(self, config=config, device=device) | ||
| self.rope_kwargs = {"dim": dim, "base": base} |
There was a problem hiding this comment.
I think a PR #35589 might have removed the kwargs! but happy to add them back if need or just not use the gemma one!
There was a problem hiding this comment.
I'll reintroduce the rope_kwargs in LlamaRotaryEmbedding.
…to modernbert/rotary_embeds
ArthurZucker
reviewed
Jan 9, 2025
…odular_modernbert" This reverts commit 11b44b9.
ArthurZucker
approved these changes
Jan 10, 2025
ArthurZucker
pushed a commit
that referenced
this pull request
Jan 10, 2025
#35459) * Introduce 5 integration tests for the 4 model classes + torch export * ModernBert: reuse GemmaRotaryEmbedding via modular * Revert #35589, keep rope_kwargs; rely on them in modular_modernbert * Revert "Revert #35589, keep rope_kwargs; rely on them in modular_modernbert" This reverts commit 11b44b9. * Don't set rope_kwargs; override 'self.rope_init_fn' call instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Note that I based the expected values from the integration tests on the
mainimplementation, not the RotaryEmbedding refactored implementation. In short: the test passes indicate that the refactor preserves the performance.This is the refactor that I promised earlier offline.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker
cc @warner-benjamin