Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert low cpu mem tie weights #29135

Merged
merged 2 commits into from Feb 20, 2024
Merged

Revert low cpu mem tie weights #29135

merged 2 commits into from Feb 20, 2024

Conversation

amyeroberts
Copy link
Collaborator

@amyeroberts amyeroberts commented Feb 20, 2024 •
edited

What does this PR do?

Reverts #28948 and #29043

See relevant comment: #29110 (comment)

cc @hackyon @ydshieh

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

ArthurZucker
ArthurZucker approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@hackyon
Copy link
Contributor

hackyon commented Feb 20, 2024

Sounds good, thanks for taking care of this!

@amyeroberts amyeroberts merged commit 0996a10 into huggingface:main Feb 20, 2024
18 checks passed
@amyeroberts amyeroberts deleted the revert-low-cpu-mem-tie-weights branch February 20, 2024 12:06
itazap pushed a commit that referenced this pull request May 14, 2024
@amyeroberts
Revert low cpu mem tie weights (#29135)
5a3ba41 
* Revert "Add tie_weights() to LM heads and set bias in set_output_embeddings() (#28948)"

This reverts commit 725f4ad.

* Revert "Patch to skip failing `test_save_load_low_cpu_mem_usage` tests (#29043)"

This reverts commit 4156f51.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurZucker ArthurZucker ArthurZucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amyeroberts @HuggingFaceDocBuilderDev @hackyon @ArthurZucker