Generate: unset GenerationConfig parameters do not raise warning #29119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
fxmarty
approved these changes
Feb 20, 2024
amyeroberts
reviewed
Feb 20, 2024
| @@ -330,7 +330,6 @@ def generate( | |||
|
|
|||
| generation_config = copy.deepcopy(generation_config) | |||
| model_kwargs = generation_config.update(**kwargs) # All unused kwargs must be model kwargs | |||
| generation_config.validate() | |||
There was a problem hiding this comment.
Why get rid of these validations here (and in the other utils files)?
There was a problem hiding this comment.
Because I've added the .validate() call to .update(), which is the line that precedes all these removals :) It makes more sense to validate at update time, rather than relying on the user to manually validate.
gante
commented
Feb 20, 2024
| # parameters with `do_sample=False`). May be escalated to an error in the future. | ||
| with warnings.catch_warnings(record=True) as captured_warnings: | ||
| GenerationConfig(temperature=0.5) | ||
| GenerationConfig(do_sample=False, temperature=0.5) |
There was a problem hiding this comment.
This commit I've made a few implicit parameters explicit, to make reading the test easier :)
amyeroberts
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Thank you @fxmarty for raising this issue.
This PR allows users to unset (= set to
None) unused parameters to ensuregeneration_config.validate()doesn't throw a warning. Previously, this was not possible when a parameter had a non-Nonedefault.For instance, the following snippet would throw a warning before this PR: