Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[from_pretrained] Make from_pretrained fast again #27709

Merged
merged 21 commits into from Dec 11, 2023
Merged

[from_pretrained] Make from_pretrained fast again #27709

merged 21 commits into from Dec 11, 2023

Conversation

ArthurZucker
Copy link
Collaborator

@ArthurZucker ArthurZucker commented Nov 26, 2023

what does this PR do

Skips all layer initialization when loading from pretrained without accelerate.

From ~20seconds to 5 seconds for a 7B model like llama.

The Weights are effectively initialized in « init_weights_ » of the pretrained method. All internal calls are skipped

  • Check that if a linear layer is missing it will be initialized! (Loading AutoModelForCausalLM from AutoModel

fixes #26258 and fixes #18505

model = XXXX.from_pretrained(model_id, torch_dtype=torch.float16, low_cpu_mem_usage=True") might fail

@ArthurZucker ArthurZucker marked this pull request as ready for review December 11, 2023 07:04
@ArthurZucker
Copy link
Collaborator Author

  • explicit overwrite breaks fx and is not that faster
  • Non initialized is not always zeros (failing tests) just make sure it’s not initialized

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart, albeit a bit manual 😄

LGTM

tests/test_modeling_common.py Outdated Show resolved Hide resolved
tests/test_modeling_common.py Outdated Show resolved Hide resolved
tests/test_modeling_common.py Outdated Show resolved Hide resolved
src/transformers/modeling_utils.py Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ArthurZucker ArthurZucker merged commit 0676d99 into main Dec 11, 2023
21 checks passed
@ArthurZucker ArthurZucker deleted the fast-init branch December 11, 2023 11:38
iantbutler01 pushed a commit to LaconicAI/transformers that referenced this pull request Dec 16, 2023
* Skip nn.Module.reset_parameters

* Actually skip

* Check quality

* Maybe change all inits

* Fix init issues: only modify public functions

* Add a small test for now

* Style

* test updates

* style

* nice tes

* style

* make it even faster

* one more second

* remove fx icompatible

* Update tests/test_modeling_common.py

Co-authored-by: Lysandre Debut <hi@lysand.re>

* Update tests/test_modeling_common.py

Co-authored-by: Lysandre Debut <hi@lysand.re>

* skip

* fix quality

* protect the import

---------

Co-authored-by: Lysandre Debut <hi@lysand.re>
staghado pushed a commit to staghado/transformers that referenced this pull request Jan 15, 2024
* Skip nn.Module.reset_parameters

* Actually skip

* Check quality

* Maybe change all inits

* Fix init issues: only modify public functions

* Add a small test for now

* Style

* test updates

* style

* nice tes

* style

* make it even faster

* one more second

* remove fx icompatible

* Update tests/test_modeling_common.py

Co-authored-by: Lysandre Debut <hi@lysand.re>

* Update tests/test_modeling_common.py

Co-authored-by: Lysandre Debut <hi@lysand.re>

* skip

* fix quality

* protect the import

---------

Co-authored-by: Lysandre Debut <hi@lysand.re>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants