Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF Swiftformer #22771

Closed
2 tasks done
amyeroberts opened this issue Apr 14, 2023 · 11 comments · Fixed by #23342
Closed
2 tasks done

TF Swiftformer #22771

amyeroberts opened this issue Apr 14, 2023 · 11 comments · Fixed by #23342

Comments

@amyeroberts
Copy link
Collaborator

Model description

Add the TensorFlow port of the SwiftFormer model. See related issue: #22685

To be done once the SwiftFormer model has been added: #22686

Open source status

  • The model implementation is available
  • The model weights are available

Provide useful links for the implementation

Original repo: https://github.com/amshaker/swiftformer

@joaocmd
Copy link
Contributor

joaocmd commented Apr 17, 2023

Hi! I would like to take on this as my first issue if possible. Is that okay?

@amyeroberts
Copy link
Collaborator Author

@joaocmd Of course! Cool issue to start on 🤗

If you haven't seen it already, there's a detailed guide in the docs on porting a model to TensorFlow: https://huggingface.co/docs/transformers/add_tensorflow_model

It's best to wait until the PyTorch implementation is merged in, which will be at least a day or two away.

@joaocmd
Copy link
Contributor

joaocmd commented Apr 18, 2023

Sounds great @amyeroberts, thank you :)

I'll start looking into it once the PyTorch PR is merged.

@D-Roberts
Copy link
Contributor

Any news on this tf model?

@joaocmd
Copy link
Contributor

joaocmd commented Apr 22, 2023

Hi @D-Roberts, I haven't started looking into it as the pytorch version has not yet been merged.

@joaocmd joaocmd mentioned this issue May 12, 2023
5 tasks
@shehanmunasinghe
Copy link
Contributor

Hi @joaocmd , the PyTorch version of SwiftFormer is now merged so you can continue working the TensorFlow version of it.

@joaocmd
Copy link
Contributor

joaocmd commented May 13, 2023

Hi @shehanmunasinghe, I'm on it, thanks!

@sqali
Copy link
Contributor

sqali commented Jul 5, 2023

Hi @amyeroberts ,

May I proceed to work on this issue if it has not been sorted yet?

@amyeroberts
Copy link
Collaborator Author

@sqali There is currently an open PR which is actively being worked on by @joaocmd: #23342

@sqali
Copy link
Contributor

sqali commented Jul 6, 2023

Hi @amyeroberts ,

Is there any other issue that you are working on in which I can help you with?

@amyeroberts
Copy link
Collaborator Author

@sqali Here's a page in the docs all about different ways to contribute and how to find issues to work on: https://huggingface.co/docs/transformers/main/contributing. I'd suggest looking at issues marked with the 'Good First Issues' tag and finding one which no-one is currently working on: Good First Issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants