Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyo3: update to 0.20 #1386

Merged
merged 1 commit into from
Jan 11, 2024
Merged

pyo3: update to 0.20 #1386

merged 1 commit into from
Jan 11, 2024

Conversation

mikelui
Copy link
Contributor

@mikelui mikelui commented Nov 11, 2023

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@github-actions github-actions bot added the Stale label Dec 12, 2023
@github-actions github-actions bot closed this Dec 17, 2023
@ArthurZucker
Copy link
Collaborator

Thanks for opening the PR and sorry for missing it

@alanhdu
Copy link

alanhdu commented Jan 9, 2024

@ArthurZucker @mikelui -- would it be possible to re-open the PR and merge it in? It looks like it got closed as stale but was not actually merged (at least https://github.com/huggingface/tokenizers/blob/main/bindings/python/Cargo.toml#L17 still points to 0.19)

@mikelui
Copy link
Contributor Author

mikelui commented Jan 10, 2024

I planned on updating this before end of week

@Narsil Narsil reopened this Jan 10, 2024
Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ArthurZucker for confirmation.

@Narsil
Copy link
Collaborator

Narsil commented Jan 10, 2024

@mikelui what is missing here ?

@mikelui
Copy link
Contributor Author

mikelui commented Jan 10, 2024

@mikelui what is missing here ?

nothing, just wanted to check if there were any tangible changes that would affect merge

@github-actions github-actions bot removed the Stale label Jan 11, 2024
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me thanks!

@ArthurZucker ArthurZucker merged commit 888dd4b into huggingface:main Jan 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants