Skip to content

Fix missing arg for transpose in AdaLora #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2023
Merged

Fix missing arg for transpose in AdaLora #347

merged 1 commit into from
May 3, 2023
+2 −1

Conversation

yasyf
Copy link
Contributor

@yasyf yasyf commented Apr 20, 2023

transpose() missing 1 required positional argument: 'fan_in_fan_out'

@yasyf
Copy link
Contributor Author

yasyf commented Apr 20, 2023

@pacman100

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 26, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

pacman100
pacman100 approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yasyf for the fix! 🤗

@pacman100
Copy link
Contributor

Could you do make style and make quality to fix the quality issues?

@yasyf
Fix missing arg for transpose in AdaLora

Verified

This commit was signed with the committer’s verified signature.
yasyf Yasyf Mohamedali
GPG key ID: F7ECDD88A700D73A
Verified
Learn about vigilant mode
7aaf0fe 
`transpose() missing 1 required positional argument: 'fan_in_fan_out'`
@yasyf
Copy link
Contributor Author

yasyf commented Apr 28, 2023

@pacman100 done!

@pacman100 pacman100 merged commit 8e53e16 into huggingface:main May 3, 2023
@yasyf yasyf deleted the patch-1 branch May 8, 2023 20:10
Guy-Bilitski pushed a commit to Guy-Bilitski/peft that referenced this pull request May 13, 2025
@yasyf
Fix missing arg for transpose in AdaLora (huggingface#347)
78a443c 
`transpose() missing 1 required positional argument: 'fan_in_fan_out'`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@pacman100 pacman100

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yasyf @HuggingFaceDocBuilderDev @pacman100