Fix HF_ENDPOINT not handled correctly #2155
Merged
+5
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2152. Related to #2120 and to this internal slack thread.
Uploading an LFS file fails because RepoUrl(...).endpoint was not correctly overwritten with HF_ENDPOINT. We were only overwriting
RepoUrl(...).endpoint
but not the inner valuestr(RepoUrl(...))
. This PR definitely fixes this by replacing it before parsing the string value. cc @padeoe.Tips from @padeoe to reproduce the issue:
/etc/hosts
or `` to deactivate traffic to huggingace.co