Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ModelStatus compute type #2047

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Fix ModelStatus compute type #2047

merged 1 commit into from
Feb 26, 2024

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Feb 26, 2024

Following the "compute type" revampt in API Inference (here - internal PR) cc @Narsil. Now the expected compute_type is not a string anymore but a dictionary. Example: gpu becomes {'gpu': {'gpu': 'a100', 'count': 8}}.

Not problematic for huggingface_hub (I don't expect anyone to have used this) but let's fix the test/docstrings.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.65%. Comparing base (46b38c2) to head (428fb78).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2047       +/-   ##
===========================================
+ Coverage   45.35%   80.65%   +35.29%     
===========================================
  Files          71       71               
  Lines        8523     8523               
===========================================
+ Hits         3866     6874     +3008     
+ Misses       4657     1649     -3008     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wauplin Wauplin merged commit 247b9fd into main Feb 26, 2024
16 checks passed
@Wauplin Wauplin deleted the fix-model-status-compute-type branch February 26, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants