Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing the headers to hf_transfer download. #1444

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Conversation

Narsil
Copy link
Contributor

@Narsil Narsil commented Apr 19, 2023

  • This is necessary for private models download.
  • It was enabled in hf_transfer==0.1.3.

- This is necessary for private models download.
- It was enabled in `hf_transfer==0.1.3`.
@Narsil Narsil requested a review from Wauplin April 19, 2023 12:31
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 19, 2023

The documentation is not available anymore as the PR was closed or merged.

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (a433410) 82.53% compared to head (4f27b44) 82.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1444      +/-   ##
==========================================
- Coverage   82.53%   82.51%   -0.02%     
==========================================
  Files          53       53              
  Lines        5633     5633              
==========================================
- Hits         4649     4648       -1     
- Misses        984      985       +1     
Impacted Files Coverage Δ
src/huggingface_hub/file_download.py 85.05% <0.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Wauplin Wauplin merged commit 3f2cd59 into main Apr 20, 2023
@Wauplin Wauplin deleted the pass_headers_hf_transfer branch April 20, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants