Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alpha-VLLM Team] Add Lumina-T2X to diffusers #8652

Merged
merged 103 commits into from
Jul 8, 2024

Conversation

PommesPeter
Copy link
Contributor

@PommesPeter PommesPeter commented Jun 20, 2024

What does this PR do?

Add Lumina-T2X to diffusers

Fixes #8652

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Sorry, something went wrong.

@PommesPeter PommesPeter mentioned this pull request Jun 20, 2024
2 tasks
@PommesPeter PommesPeter changed the title Add Lumina-T2X to diffusers [WIP] Add Lumina-T2X to diffusers Jun 20, 2024
@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Jul 5, 2024

can you run make fix-copies again?

@PommesPeter
Copy link
Contributor Author

can you run make fix-copies again?

run it~

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Jul 5, 2024

@PommesPeter lumina tests still fail
I think we need to update the lumina tests now because we made updates to the model

@PommesPeter
Copy link
Contributor Author

@PommesPeter lumina tests still fail I think we need to update the lumina tests now because we made updates to the model

yep, we have fixed the problem from test class.

@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Jul 5, 2024

@PommesPeter we need the make style again, sorry!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@vladmandic
Copy link
Contributor

vladmandic commented Jul 6, 2024

not sure what's the status of the pr since simple load is still failing?

pip install git+https://github.com/PommesPeter/diffusers@lumina

import torch
from diffusers import LuminaText2ImgPipeline
pipe = LuminaText2ImgPipeline.from_pretrained("Alpha-VLLM/Lumina-Next-SFT-diffusers", torch_dtype=torch.bfloat16).cuda()
ValueError: Cannot load <class 'diffusers.models.transformers.lumina_nextdit2d.LuminaNextDiT2DModel'> from /mnt/models/Diffusers/models--Alpha-VLLM--Lumina-Next-SFT-diffusers/snapshots/f82702c1b6a9bac3db9155edad1fd8dbf088cdf6/transformer because the following keys are missing:
...

@PommesPeter
Copy link
Contributor Author

not sure what's the status of the pr since simple load is still failing?

pip install git+https://github.com/PommesPeter/diffusers@lumina

import torch
from diffusers import LuminaText2ImgPipeline
pipe = LuminaText2ImgPipeline.from_pretrained("Alpha-VLLM/Lumina-Next-SFT-diffusers", torch_dtype=torch.bfloat16).cuda()
ValueError: Cannot load <class 'diffusers.models.transformers.lumina_nextdit2d.LuminaNextDiT2DModel'> from /mnt/models/Diffusers/models--Alpha-VLLM--Lumina-Next-SFT-diffusers/snapshots/f82702c1b6a9bac3db9155edad1fd8dbf088cdf6/transformer because the following keys are missing:
...

sorry, we have network problem in pushing our newest model to huggingface. I'm re-pushing the newest model for lumina.

@PommesPeter
Copy link
Contributor Author

not sure what's the status of the pr since simple load is still failing?

pip install git+https://github.com/PommesPeter/diffusers@lumina

import torch
from diffusers import LuminaText2ImgPipeline
pipe = LuminaText2ImgPipeline.from_pretrained("Alpha-VLLM/Lumina-Next-SFT-diffusers", torch_dtype=torch.bfloat16).cuda()
ValueError: Cannot load <class 'diffusers.models.transformers.lumina_nextdit2d.LuminaNextDiT2DModel'> from /mnt/models/Diffusers/models--Alpha-VLLM--Lumina-Next-SFT-diffusers/snapshots/f82702c1b6a9bac3db9155edad1fd8dbf088cdf6/transformer because the following keys are missing:
...

sorry, we have network problem in pushing our newest model to huggingface. I'm re-pushing the newest model for lumina.

Hi @vladmandic
we have pushed our model to huggingface repo. could you re-pull the huggingface model repo for testing you want?

yiyixuxu added 2 commits July 6, 2024 10:06

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Jul 6, 2024

@PommesPeter
can you check if you need to update the slow tests? since the checkpoints have been updated a couple of times
I will merge it tomorrow once the slow tests are updated

@PommesPeter
Copy link
Contributor Author

@PommesPeter can you check if you need to update the slow tests? since the checkpoints have been updated a couple of times I will merge it tomorrow once the slow tests are updated

okay, i will fix the problem.

@vladmandic
Copy link
Contributor

vladmandic commented Jul 6, 2024

@PommesPeter confirmed as working with updated model on hf.

PommesPeter and others added 2 commits July 8, 2024 10:14
@yiyixuxu yiyixuxu merged commit 9838867 into huggingface:main Jul 8, 2024
14 of 15 checks passed
@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Jul 8, 2024

merged! thank you!

@PommesPeter
Copy link
Contributor Author

wow! thank you for your reviewing to our pr

@ylacombe ylacombe mentioned this pull request Jul 10, 2024
5 tasks
sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
---------

Co-authored-by: zhuole1025 <zhuole1025@gmail.com>
Co-authored-by: YiYi Xu <yixu310@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants